Skip to content

[25.2] Remove bytes counters, fix issues returning and logs for BATCH operations (#28853) #28861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2025
Merged

[25.2] Remove bytes counters, fix issues returning and logs for BATCH operations (#28853) #28861

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions ydb/core/kqp/counters/kqp_counters.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -896,11 +896,7 @@ TKqpCounters::TKqpCounters(const ::NMonitoring::TDynamicCounterPtr& counters, co

/* Statistics batch operations */
BatchOperationUpdateRows = KqpGroup->GetCounter("BatchOperation/Update/Rows", true);
BatchOperationUpdateBytes = KqpGroup->GetCounter("BatchOperation/Update/Bytes", true);

BatchOperationDeleteRows = KqpGroup->GetCounter("BatchOperation/Delete/Rows", true);
BatchOperationDeleteBytes = KqpGroup->GetCounter("BatchOperation/Delete/Bytes", true);

BatchOperationRetries = KqpGroup->GetCounter("BatchOperation/Retries", true);
}

Expand Down
2 changes: 0 additions & 2 deletions ydb/core/kqp/counters/kqp_counters.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,9 +487,7 @@ class TKqpCounters : public TKqpCountersBase, public NYql::NDq::TSpillingCounter

// Statistics batch operations
::NMonitoring::TDynamicCounters::TCounterPtr BatchOperationUpdateRows;
::NMonitoring::TDynamicCounters::TCounterPtr BatchOperationUpdateBytes;
::NMonitoring::TDynamicCounters::TCounterPtr BatchOperationDeleteRows;
::NMonitoring::TDynamicCounters::TCounterPtr BatchOperationDeleteBytes;
::NMonitoring::TDynamicCounters::TCounterPtr BatchOperationRetries;
};

Expand Down
3 changes: 0 additions & 3 deletions ydb/core/kqp/executer_actor/kqp_executer_impl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2175,10 +2175,7 @@ class TKqpExecuterBase : public TActor<TDerived> {
if (!BatchOperationSettings.Empty() && !Stats->TableStats.empty()) {
auto [_, tableStats] = *Stats->TableStats.begin();
Counters->Counters->BatchOperationUpdateRows->Add(tableStats->GetWriteRows());
Counters->Counters->BatchOperationUpdateBytes->Add(tableStats->GetWriteBytes());

Counters->Counters->BatchOperationDeleteRows->Add(tableStats->GetEraseRows());
Counters->Counters->BatchOperationDeleteBytes->Add(tableStats->GetEraseBytes());
}

auto finishSize = Stats->EstimateFinishMem();
Expand Down
Loading
Loading