Skip to content

[25.2] Impl methods to detect BulkUpsert with DEFAULT columns and a flag to disable (#27596) #28871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2025
Merged

[25.2] Impl methods to detect BulkUpsert with DEFAULT columns and a flag to disable (#27596) #28871

merged 1 commit into from
Nov 14, 2025

Conversation

@dahbka-lis
Copy link
Member

@dahbka-lis dahbka-lis commented Nov 14, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@dahbka-lis
Impl methods to detect BulkUpsert with DEFAULT columns and a flag to …
de5c8d5 
…disable (ydb-platform#27596)

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@dahbka-lis dahbka-lis requested a review from a team as a code owner November 14, 2025 07:14
@github-actions
Copy link

github-actions bot commented Nov 14, 2025

🟢 2025-11-14 07:17:47 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Nov 14, 2025 •
edited
Loading

⚪ 2025-11-14 07:18:28 UTC Pre-commit check linux-x86_64-release-asan for 29fa84f has started.
⚪ 2025-11-14 07:18:42 UTC Artifacts will be uploaded here
⚪ 2025-11-14 07:22:03 UTC ya make is running...
🟡 2025-11-14 09:01:35 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14862 14695 0 31 104 32

⚪ 2025-11-14 09:02:46 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-11-14 09:26:43 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
202 (only retried tests) 167 0 3 3 29

⚪ 2025-11-14 09:26:52 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-11-14 09:38:08 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
64 (only retried tests) 32 0 1 0 31

🟢 2025-11-14 09:38:16 UTC Build successful.
🟢 2025-11-14 09:38:40 UTC ydbd size 3.8 GiB changed* by +36.8 KiB, which is < 100.0 KiB vs stable-25-2: OK

ydbd size dash stable-25-2: 3c28b5a merge: 29fa84f diff diff %
ydbd size 4 050 151 216 Bytes 4 050 188 904 Bytes +36.8 KiB +0.001%
ydbd stripped size 1 409 740 856 Bytes 1 409 748 408 Bytes +7.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@dahbka-lis dahbka-lis enabled auto-merge November 14, 2025 07:18
@github-actions
Copy link

github-actions bot commented Nov 14, 2025 •
edited
Loading

⚪ 2025-11-14 07:18:52 UTC Pre-commit check linux-x86_64-relwithdebinfo for 29fa84f has started.
⚪ 2025-11-14 07:19:07 UTC Artifacts will be uploaded here
⚪ 2025-11-14 07:22:40 UTC ya make is running...
🟡 2025-11-14 08:58:07 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
35984 33461 0 4 2472 47

⚪ 2025-11-14 09:01:02 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-11-14 09:13:37 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
98 (only retried tests) 56 0 3 5 34

⚪ 2025-11-14 09:13:46 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-11-14 09:41:07 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
71 (only retried tests) 35 0 1 2 33

🟢 2025-11-14 09:41:13 UTC Build successful.
🟢 2025-11-14 09:41:33 UTC ydbd size 2.2 GiB changed* by +27.1 KiB, which is < 100.0 KiB vs stable-25-2: OK

ydbd size dash stable-25-2: 3c28b5a merge: 29fa84f diff diff %
ydbd size 2 327 116 560 Bytes 2 327 144 320 Bytes +27.1 KiB +0.001%
ydbd stripped size 487 624 744 Bytes 487 631 976 Bytes +7.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@dahbka-lis dahbka-lis added the rebase-and-check Rebase PR with the current base branch and check label Nov 14, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Nov 14, 2025
@github-actions
Copy link

github-actions bot commented Nov 14, 2025 •
edited
Loading

⚪ 2025-11-14 09:46:31 UTC Pre-commit check linux-x86_64-release-asan for f6cad3d has started.
⚪ 2025-11-14 09:46:45 UTC Artifacts will be uploaded here
⚪ 2025-11-14 09:50:08 UTC ya make is running...
🟡 2025-11-14 11:02:12 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14862 14629 0 91 110 32

⚪ 2025-11-14 11:03:25 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-11-14 11:15:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
276 (only retried tests) 236 0 3 5 32

⚪ 2025-11-14 11:15:34 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-11-14 11:32:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
68 (only retried tests) 34 0 1 4 29

🟢 2025-11-14 11:32:27 UTC Build successful.
🟢 2025-11-14 11:32:52 UTC ydbd size 3.8 GiB changed* by +40.8 KiB, which is < 100.0 KiB vs stable-25-2: OK

ydbd size dash stable-25-2: a5a7124 merge: f6cad3d diff diff %
ydbd size 4 050 268 536 Bytes 4 050 310 320 Bytes +40.8 KiB +0.001%
ydbd stripped size 1 409 776 440 Bytes 1 409 788 088 Bytes +11.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 14, 2025 •
edited
Loading

⚪ 2025-11-14 09:47:54 UTC Pre-commit check linux-x86_64-relwithdebinfo for f6cad3d has started.
⚪ 2025-11-14 09:48:11 UTC Artifacts will be uploaded here
⚪ 2025-11-14 09:51:42 UTC ya make is running...
🟡 2025-11-14 11:03:15 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
35984 33459 0 7 2472 46

⚪ 2025-11-14 11:06:08 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-11-14 11:18:33 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
98 (only retried tests) 57 0 1 4 36

⚪ 2025-11-14 11:18:41 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-11-14 11:30:48 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
70 (only retried tests) 32 0 0 3 35

🟢 2025-11-14 11:30:55 UTC Build successful.
🟢 2025-11-14 11:31:14 UTC ydbd size 2.2 GiB changed* by +27.1 KiB, which is < 100.0 KiB vs stable-25-2: OK

ydbd size dash stable-25-2: a5a7124 merge: f6cad3d diff diff %
ydbd size 2 327 187 720 Bytes 2 327 215 472 Bytes +27.1 KiB +0.001%
ydbd stripped size 487 642 856 Bytes 487 650 088 Bytes +7.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@dahbka-lis dahbka-lis merged commit ad6aeae into ydb-platform:stable-25-2 Nov 14, 2025
14 of 15 checks passed
@dahbka-lis dahbka-lis linked an issue Nov 14, 2025 that may be closed by this pull request
BulkUpsert without DEFAULT columns fills NULLs, not literals #27555
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maximyurchuk maximyurchuk maximyurchuk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BulkUpsert without DEFAULT columns fills NULLs, not literals

2 participants

@dahbka-lis @maximyurchuk