Skip to content

Conversation

@pixcc
Copy link
Member

@pixcc pixcc commented Nov 14, 2025

Changelog entry

Fixes #27228

Changelog category

  • Bugfix

Description for reviewers

  • Adds FirstBootTimestamp tracking in CMS persistent state
  • Introduces InitialDeploymentGracePeriod configuration parameter (default: 10 minutes)
  • Modifies PDisk status computation to skip INACTIVE phase for Normal state within grace period

Copilot AI review requested due to automatic review settings November 14, 2025 10:16
@pixcc pixcc requested a review from a team as a code owner November 14, 2025 10:16
@pixcc pixcc requested a review from Enjection November 14, 2025 10:16
@pixcc pixcc marked this pull request as draft November 14, 2025 10:16
@pixcc pixcc linked an issue Nov 14, 2025 that may be closed by this pull request
@github-actions

This comment was marked as outdated.

@github-actions
Copy link

github-actions bot commented Nov 14, 2025

🟢 2025-11-26 10:01:14 UTC The validation of the Pull Request description is successful.

Copilot finished reviewing on behalf of pixcc November 14, 2025 10:20
@github-actions

This comment was marked as outdated.

This comment was marked as outdated.

@pixcc pixcc changed the title Add initial_deployment_grace_period to Sentinel (SelfHeal) Fix that disks may become INACTIVE during cluster bootstrap Nov 26, 2025
@github-actions

This comment was marked as outdated.

@pixcc pixcc requested a review from Copilot November 26, 2025 09:51
@github-actions

This comment was marked as outdated.

@pixcc pixcc requested a review from CyberROFL November 26, 2025 09:54
@github-actions github-actions bot added bugfix and removed bugfix labels Nov 26, 2025
Copilot finished reviewing on behalf of pixcc November 26, 2025 09:56

This comment was marked as outdated.

@pixcc pixcc marked this pull request as ready for review November 26, 2025 09:58
@github-actions github-actions bot removed the bugfix label Nov 26, 2025
@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@pixcc pixcc requested a review from CyberROFL November 26, 2025 14:17
@github-actions
Copy link

github-actions bot commented Nov 26, 2025

2025-11-26 14:19:45 UTC Pre-commit check linux-x86_64-relwithdebinfo for e434acd has started.
2025-11-26 14:20:02 UTC Artifacts will be uploaded here
2025-11-26 14:22:15 UTC ya make is running...
🟡 2025-11-26 16:36:00 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41634 38759 0 3 2853 19

2025-11-26 16:36:14 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-11-26 16:46:13 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
62 (only retried tests) 50 0 0 0 12

🟢 2025-11-26 16:46:20 UTC Build successful.
🟢 2025-11-26 16:46:45 UTC ydbd size 2.3 GiB changed* by +57.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: c875917 merge: e434acd diff diff %
ydbd size 2 456 472 400 Bytes 2 456 531 592 Bytes +57.8 KiB +0.002%
ydbd stripped size 523 448 384 Bytes 523 451 776 Bytes +3.3 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 26, 2025

2025-11-26 14:21:42 UTC Pre-commit check linux-x86_64-release-asan for e434acd has started.
2025-11-26 14:21:59 UTC Artifacts will be uploaded here
2025-11-26 14:24:10 UTC ya make is running...
🟡 2025-11-26 16:19:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13478 13345 0 114 7 12

🟢 2025-11-26 16:19:50 UTC Build successful.
🟢 2025-11-26 16:20:16 UTC ydbd size 3.8 GiB changed* by +82.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: c875917 merge: e434acd diff diff %
ydbd size 4 111 923 912 Bytes 4 112 008 592 Bytes +82.7 KiB +0.002%
ydbd stripped size 1 528 251 056 Bytes 1 528 268 080 Bytes +16.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disks may become INACTIVE during cluster bootstrap

3 participants