Skip to content

Fixed possible crash on creating the transfer (#28895) #28914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2025
Merged

Fixed possible crash on creating the transfer (#28895) #28914

merged 1 commit into from
Nov 15, 2025
+22 −4

Conversation

@nshestakov
Copy link
Collaborator

@nshestakov nshestakov commented Nov 14, 2025

Changelog entry

Если создавать трансфер в несуществующей директории, то сервер упадет по верифайке. Ожидаемое поведение - будут созданы недостающие директории.

Поведение поправлено

Changelog category

  • Bugfix

Description for reviewers

LOGBROKER-10079

@nshestakov nshestakov requested a review from a team as a code owner November 14, 2025 15:34
@github-actions
Copy link

github-actions bot commented Nov 14, 2025 •
edited
Loading

⚪ 2025-11-14 15:35:18 UTC Pre-commit check linux-x86_64-relwithdebinfo for b5a9e0b has started.
⚪ 2025-11-14 15:35:25 UTC Artifacts will be uploaded here
⚪ 2025-11-14 15:39:07 UTC ya make is running...
🟡 2025-11-14 17:14:12 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38616 35928 0 15 2650 23

⚪ 2025-11-14 17:17:54 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-11-14 17:37:55 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
583 (only retried tests) 555 0 4 1 23

⚪ 2025-11-14 17:38:07 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-11-14 17:55:06 UTC Some tests failed, follow the links below.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
542 (only retried tests) 522 0 1 0 19

🟢 2025-11-14 17:55:15 UTC Build successful.
🟢 2025-11-14 17:55:35 UTC ydbd size 2.3 GiB changed* by +2.8 KiB, which is < 100.0 KiB vs stable-25-3: OK

ydbd size dash stable-25-3: bfe2b9f merge: b5a9e0b diff diff %
ydbd size 2 440 664 576 Bytes 2 440 667 488 Bytes +2.8 KiB +0.000%
ydbd stripped size 522 447 880 Bytes 522 448 328 Bytes +448 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 14, 2025

🟢 2025-11-14 15:36:10 UTC The validation of the Pull Request description is successful.

@nshestakov nshestakov enabled auto-merge November 14, 2025 15:39
@github-actions
Copy link

github-actions bot commented Nov 14, 2025 •
edited
Loading

⚪ 2025-11-14 15:39:40 UTC Pre-commit check linux-x86_64-release-asan for b5a9e0b has started.
⚪ 2025-11-14 15:39:54 UTC Artifacts will be uploaded here
⚪ 2025-11-14 15:43:33 UTC ya make is running...
🟡 2025-11-14 17:48:20 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15755 15275 0 211 252 17

🟢 2025-11-14 17:49:50 UTC Build successful.
🟢 2025-11-14 17:50:14 UTC ydbd size 3.8 GiB changed* by +4.6 KiB, which is < 100.0 KiB vs stable-25-3: OK

ydbd size dash stable-25-3: bfe2b9f merge: b5a9e0b diff diff %
ydbd size 4 062 226 336 Bytes 4 062 231 072 Bytes +4.6 KiB +0.000%
ydbd stripped size 1 513 754 944 Bytes 1 513 756 096 Bytes +1.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nshestakov nshestakov added the rebase-and-check Rebase PR with the current base branch and check label Nov 14, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Nov 14, 2025
@github-actions
Copy link

github-actions bot commented Nov 14, 2025 •
edited
Loading

⚪ 2025-11-14 18:10:52 UTC Pre-commit check linux-x86_64-release-asan for 58cda5d has started.
⚪ 2025-11-14 18:11:09 UTC Artifacts will be uploaded here
⚪ 2025-11-14 18:14:44 UTC ya make is running...
🟡 2025-11-14 20:24:20 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15755 15208 0 241 288 18

🟢 2025-11-14 20:25:38 UTC Build successful.
🟡 2025-11-14 20:26:04 UTC ydbd size 3.8 GiB changed* by +488.1 KiB, which is >= 100.0 KiB vs stable-25-3: Warning

ydbd size dash stable-25-3: bfe2b9f merge: 58cda5d diff diff %
ydbd size 4 062 226 336 Bytes 4 062 726 160 Bytes +488.1 KiB +0.012%
ydbd stripped size 1 513 754 944 Bytes 1 513 912 736 Bytes +154.1 KiB +0.010%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 14, 2025 •
edited
Loading

⚪ 2025-11-14 18:13:34 UTC Pre-commit check linux-x86_64-relwithdebinfo for 58cda5d has started.
⚪ 2025-11-14 18:13:48 UTC Artifacts will be uploaded here
⚪ 2025-11-14 18:17:22 UTC ya make is running...
🟡 2025-11-14 19:46:04 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38616 35936 0 11 2650 19

⚪ 2025-11-14 19:49:28 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-11-14 20:08:49 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
595 (only retried tests) 566 0 4 5 20

⚪ 2025-11-14 20:08:59 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-11-14 20:24:39 UTC Some tests failed, follow the links below.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
544 (only retried tests) 523 0 1 0 20

🟢 2025-11-14 20:24:50 UTC Build successful.
🟢 2025-11-14 20:25:10 UTC ydbd size 2.3 GiB changed* by +2.8 KiB, which is < 100.0 KiB vs stable-25-3: OK

ydbd size dash stable-25-3: 91f82ed merge: 58cda5d diff diff %
ydbd size 2 440 976 872 Bytes 2 440 979 784 Bytes +2.8 KiB +0.000%
ydbd stripped size 522 505 416 Bytes 522 505 864 Bytes +448 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nshestakov nshestakov added the rebase-and-check Rebase PR with the current base branch and check label Nov 15, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Nov 15, 2025
@github-actions
Copy link

github-actions bot commented Nov 15, 2025 •
edited
Loading

⚪ 2025-11-15 04:25:13 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9df02d6 has started.
⚪ 2025-11-15 04:25:26 UTC Artifacts will be uploaded here
⚪ 2025-11-15 04:29:11 UTC ya make is running...
🟡 2025-11-15 05:53:37 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38616 35940 0 3 2650 23

⚪ 2025-11-15 06:07:47 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-11-15 06:24:37 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
556 (only retried tests) 538 0 1 0 17

⚪ 2025-11-15 06:24:47 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-11-15 06:39:35 UTC Tests successful.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
540 (only retried tests) 523 0 0 0 17

🟢 2025-11-15 06:39:43 UTC Build successful.
🟢 2025-11-15 06:40:03 UTC ydbd size 2.3 GiB changed* by +2.8 KiB, which is < 100.0 KiB vs stable-25-3: OK

ydbd size dash stable-25-3: 3f98865 merge: 9df02d6 diff diff %
ydbd size 2 441 045 400 Bytes 2 441 048 296 Bytes +2.8 KiB +0.000%
ydbd stripped size 522 523 784 Bytes 522 524 232 Bytes +448 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 15, 2025 •
edited
Loading

⚪ 2025-11-15 04:26:25 UTC Pre-commit check linux-x86_64-release-asan for 9df02d6 has started.
⚪ 2025-11-15 04:26:40 UTC Artifacts will be uploaded here
⚪ 2025-11-15 04:30:26 UTC ya make is running...
🟡 2025-11-15 06:47:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15755 15202 0 240 296 17

🟢 2025-11-15 06:48:57 UTC Build successful.
🟢 2025-11-15 06:49:21 UTC ydbd size 3.8 GiB changed* by +4.6 KiB, which is < 100.0 KiB vs stable-25-3: OK

ydbd size dash stable-25-3: 3f98865 merge: 9df02d6 diff diff %
ydbd size 4 062 827 808 Bytes 4 062 832 544 Bytes +4.6 KiB +0.000%
ydbd stripped size 1 513 951 584 Bytes 1 513 952 736 Bytes +1.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nshestakov nshestakov merged commit 942c0ac into ydb-platform:stable-25-3 Nov 15, 2025
18 of 20 checks passed
@nshestakov nshestakov deleted the TR-fix-verify-25-3 branch November 15, 2025 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maximyurchuk maximyurchuk maximyurchuk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nshestakov @maximyurchuk