-
Notifications
You must be signed in to change notification settings - Fork 735
YQ-4900 fixed empty streaming queries sys view without user token #29100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YQ-4900 fixed empty streaming queries sys view without user token #29100
Conversation
|
🟢 |
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a bug where streaming queries system view would be empty when accessed without a user token. The fix adds a null/empty check before assigning the UserToken to avoid issues with empty tokens.
Key Changes:
- Added conditional check for UserToken validity before assignment in streaming queries schema describe actor
- Added test case to verify streaming queries system view works without authentication
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ydb/core/sys_view/streaming_queries/streaming_queries.cpp | Adds check for UserToken and GetSanitizedToken() before assigning to request to prevent empty token issues |
| ydb/core/kqp/ut/federated_query/datastreams/datastreams_ut.cpp | Adds test case "ReadWithoutAuth" to verify system view works without authentication |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Changelog entry
Fixed empty streaming queries sys view without user token
Changelog category
Description for reviewers
Bugfix ticket: https://st.yandex-team.ru/YQ-4900