Skip to content

Conversation

@GrigoriyPA
Copy link
Collaborator

Changelog entry

Fixed empty streaming queries sys view without user token

Changelog category

  • Bugfix

Description for reviewers

Bugfix ticket: https://st.yandex-team.ru/YQ-4900

@GrigoriyPA GrigoriyPA requested a review from a team as a code owner November 18, 2025 14:33
Copilot AI review requested due to automatic review settings November 18, 2025 14:33
@github-actions
Copy link

🟢 2025-11-18 14:36:27 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Nov 18, 2025

2025-11-18 14:36:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8905037 has started.
2025-11-18 14:37:57 UTC Artifacts will be uploaded here
2025-11-18 14:39:58 UTC ya make is running...
🟡 2025-11-18 16:08:24 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39027 36153 0 2 2842 30

2025-11-18 16:08:36 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-11-18 16:23:05 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
70 (only retried tests) 56 0 0 0 14

🟢 2025-11-18 16:23:12 UTC Build successful.
🟢 2025-11-18 16:23:31 UTC ydbd size 2.3 GiB changed* by +1.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: c7db72b merge: 8905037 diff diff %
ydbd size 2 445 947 336 Bytes 2 445 948 568 Bytes +1.2 KiB +0.000%
ydbd stripped size 520 050 968 Bytes 520 051 160 Bytes +192 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 18, 2025

2025-11-18 14:37:32 UTC Pre-commit check linux-x86_64-release-asan for 8905037 has started.
2025-11-18 14:37:51 UTC Artifacts will be uploaded here
2025-11-18 14:40:03 UTC ya make is running...
🟡 2025-11-18 15:55:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12700 12564 0 113 7 16

🟢 2025-11-18 15:55:45 UTC Build successful.
🟢 2025-11-18 15:56:11 UTC ydbd size 3.8 GiB changed* by +1.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: c7db72b merge: 8905037 diff diff %
ydbd size 4 094 976 264 Bytes 4 094 977 864 Bytes +1.6 KiB +0.000%
ydbd stripped size 1 520 315 056 Bytes 1 520 315 376 Bytes +320 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copilot finished reviewing on behalf of GrigoriyPA November 18, 2025 14:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where streaming queries system view would be empty when accessed without a user token. The fix adds a null/empty check before assigning the UserToken to avoid issues with empty tokens.

Key Changes:

  • Added conditional check for UserToken validity before assignment in streaming queries schema describe actor
  • Added test case to verify streaming queries system view works without authentication

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
ydb/core/sys_view/streaming_queries/streaming_queries.cpp Adds check for UserToken and GetSanitizedToken() before assigning to request to prevent empty token issues
ydb/core/kqp/ut/federated_query/datastreams/datastreams_ut.cpp Adds test case "ReadWithoutAuth" to verify system view works without authentication

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@GrigoriyPA GrigoriyPA merged commit d24ca81 into ydb-platform:main Nov 19, 2025
18 checks passed
@GrigoriyPA GrigoriyPA deleted the YQ-4900-fix-empty-sys-view-without-user-token branch November 19, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants