-
Notifications
You must be signed in to change notification settings - Fork 735
YQ-4911 disabled transparent sys columns in PQ source #29332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YQ-4911 disabled transparent sys columns in PQ source #29332
Conversation
|
🟢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR disables transparent system columns in the PQ (Persistent Queue) source to fix a bug. The change introduces a new configuration flag AllowTransperentSystemColumns (defaulting to true for backward compatibility but set to false in KQP) that controls whether system columns can use the transparent prefix (_yql_sys_tsp_).
Key changes:
- Refactored metadata field handling to support conditional transparent system columns
- Changed from static vector to dynamic map-based system for metadata fields
- Added configuration flag to control transparent column behavior
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 24 comments.
Show a summary per file
| File | Description |
|---|---|
| ydb/library/yql/providers/pq/provider/yql_pq_provider.h | Added AllowTransperentSystemColumns flag to TPqState |
| ydb/library/yql/providers/pq/common/pq_meta_fields.h | Updated function signatures to support transparent column control |
| ydb/library/yql/providers/pq/common/pq_meta_fields.cpp | Refactored metadata field handling with new TPqMetadataField class |
| ydb/library/yql/providers/pq/provider/yql_pq_dq_integration.cpp | Updated to pass AllowTransperentSystemColumns flag |
| ydb/library/yql/providers/pq/provider/yql_pq_datasource_type_ann.cpp | Updated to pass AllowTransperentSystemColumns flag |
| ydb/library/yql/providers/pq/provider/yql_pq_datasource.cpp | Updated to pass AllowTransperentSystemColumns flag |
| ydb/library/yql/providers/pq/async_io/dq_pq_meta_extractor.cpp | Refactored to use key-based extractors instead of system column names |
| ydb/core/kqp/host/kqp_host.cpp | Set AllowTransperentSystemColumns to false in KQP host |
| ydb/core/kqp/ut/federated_query/datastreams/datastreams_ut.cpp | Added regression test for projection queries |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
⚪ Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
Disabled transparent sys columns in PQ source
Changelog category
Description for reviewers
Bugfix ticket: https://st.yandex-team.ru/YQ-4911