-
Notifications
You must be signed in to change notification settings - Fork 735
fix some comments for export column tables #29633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
🟢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes duplicate export-related files and applies code formatting improvements to function signatures in the export module. The duplicate files ydb/apps/ydbd/export.h and ydb/apps/ydbd/export.cpp are removed, as the actual implementation resides in the ydb/apps/ydbd/export/ subdirectory.
- Removes duplicate
export.handexport.cppfiles from theydb/apps/ydbd/directory - Improves code formatting by splitting long function signatures across multiple lines in
export_common.cpp - Ensures the version with proper documentation comments is retained
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ydb/core/tx/datashard/export_common.cpp | Reformats GenRowTableScheme and GenColumnTableScheme function signatures to improve readability by splitting them across multiple lines |
| ydb/apps/ydbd/export.h | Removes duplicate header file; the actual implementation exists in ydb/apps/ydbd/export/export.h |
| ydb/apps/ydbd/export.cpp | Removes duplicate implementation file; the actual implementation with proper comments exists in ydb/apps/ydbd/export/export.cpp |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This comment was marked as outdated.
This comment was marked as outdated.
|
@dorooleg не собирается. |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
...
Changelog category
Description for reviewers
comments: #28847 (review)