Skip to content

fix some comments for export column tables #29633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2025
Merged

fix some comments for export column tables #29633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e276ee
fix some comments for export column tables
dorooleg Nov 26, 2025
e79cb16
clean
dorooleg Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions ydb/apps/ydbd/export.cpp
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions ydb/apps/ydbd/export.h
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions ydb/apps/ydbd/ya.make
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ IF (OS_WINDOWS)
ENDIF()

SRCS(
export.cpp
export.h
main.cpp
)

Expand Down
12 changes: 8 additions & 4 deletions ydb/core/tx/datashard/export_common.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,10 @@ static void ResortColumns(
return it->second;
});
}
static TMaybe<Ydb::Table::CreateTableRequest> GenRowTableScheme(const TMap<ui32, TUserTable::TUserColumn>& columns,
const NKikimrSchemeOp::TPathDescription& pathDesc) {
static TMaybe<Ydb::Table::CreateTableRequest> GenRowTableScheme(
const TMap<ui32, TUserTable::TUserColumn>& columns,
const NKikimrSchemeOp::TPathDescription& pathDesc)
{
if (!pathDesc.HasTable()) {
return Nothing();
}
Expand Down Expand Up @@ -68,8 +70,10 @@ static TMaybe<Ydb::Table::CreateTableRequest> GenRowTableScheme(const TMap<ui32,
return scheme;
}

static TMaybe<Ydb::Table::CreateTableRequest> GenColumnTableScheme(const TMap<ui32, TUserTable::TUserColumn>& columns,
const NKikimrSchemeOp::TPathDescription& pathDesc) {
static TMaybe<Ydb::Table::CreateTableRequest> GenColumnTableScheme(
const TMap<ui32, TUserTable::TUserColumn>& columns,
const NKikimrSchemeOp::TPathDescription& pathDesc)
{
if (!pathDesc.HasColumnTableDescription()) {
return Nothing();
}
Expand Down
Loading