Skip to content

Bootstrapper: full node list in TBootstrapperInfo, handle possible duplicates - #9848

Merged
snaury merged 1 commit into
ydb-platform:mainfrom
snaury:bugfix-9843-bootstrapper-duplicate-nodes
Sep 27, 2024
Merged

Bootstrapper: full node list in TBootstrapperInfo, handle possible duplicates#9848
snaury merged 1 commit into
ydb-platform:mainfrom
snaury:bugfix-9843-bootstrapper-duplicate-nodes

Conversation

@snaury

@snaury snaury commented Sep 27, 2024

Copy link
Copy Markdown
Member

Changelog entry

...

Changelog category

  • Bugfix

Additional information

Bootstrapper was not working correctly when configured with node duplicates. Change TBootstrapperInfo to specify a full list of nodes, and gracefully handle duplicates by preprocessing this list.

Fixes #9843.

@github-actions github-actions Bot added bugfix and removed bugfix labels Sep 27, 2024
@github-actions

github-actions Bot commented Sep 27, 2024

Copy link
Copy Markdown
Contributor

2024-09-27 10:16:15 UTC Pre-commit check linux-x86_64-relwithdebinfo for a2afa55 has started.
2024-09-27 10:17:12 UTC Artifacts will be uploaded here
2024-09-27 10:20:49 UTC ya make is running...
🟡 2024-09-27 12:08:13 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41241 35668 0 4 5468 101

2024-09-27 12:11:41 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-27 12:28:02 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
116 (only retried tests) 23 0 0 0 93

🟢 2024-09-27 12:28:09 UTC Build successful.
🟢 2024-09-27 12:28:45 UTC ydbd size 8.5 GiB changed* by +34.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4f53f25 merge: a2afa55 diff diff %
ydbd size 9 082 891 824 Bytes 9 082 927 416 Bytes +34.8 KiB +0.000%
ydbd stripped size 490 947 144 Bytes 490 947 656 Bytes +512 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions

github-actions Bot commented Sep 27, 2024

Copy link
Copy Markdown
Contributor

2024-09-27 10:16:36 UTC Pre-commit check linux-x86_64-release-asan for a2afa55 has started.
2024-09-27 10:16:46 UTC Artifacts will be uploaded here
2024-09-27 10:19:44 UTC ya make is running...
🟡 2024-09-27 12:45:15 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11861 11636 0 53 50 122

🟢 2024-09-27 12:46:14 UTC Build successful.
🟢 2024-09-27 12:46:45 UTC ydbd size 5.7 GiB changed* by +22.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4f53f25 merge: a2afa55 diff diff %
ydbd size 6 085 566 096 Bytes 6 085 588 632 Bytes +22.0 KiB +0.000%
ydbd stripped size 1 521 117 968 Bytes 1 521 126 352 Bytes +8.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@snaury
snaury requested a review from CyberROFL September 27, 2024 10:42
@snaury snaury self-assigned this Sep 27, 2024
@snaury
snaury marked this pull request as ready for review September 27, 2024 10:42
@snaury
snaury merged commit ad0cdee into ydb-platform:main Sep 27, 2024
@snaury
snaury deleted the bugfix-9843-bootstrapper-duplicate-nodes branch September 27, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bootstrapper: don't break on duplicate nodes

2 participants