Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker run -p to README (fixes #5) #16

Merged
merged 1 commit into from
Aug 21, 2022
Merged

Conversation

vorburger
Copy link
Contributor

@vorburger vorburger commented Aug 20, 2022

see #9 (not #5)

@yegle OK for you?

@yegle
Copy link
Owner

yegle commented Aug 20, 2022

I think I'm more comfortable having a different section asking the user to add -p 5000:5000 if they want to expose the service directly.

Something like this:

NOTE: The command above does not expose service directly, so you can use your own reverse proxy. If you do want to expose the service without using a reverse proxy, you can add `-p 5000:5000` and access the service at the corresponding port.

@vorburger
Copy link
Contributor Author

@yegle I see what you mean. How about like this?

@yegle yegle merged commit 49463a2 into yegle:master Aug 21, 2022
@yegle
Copy link
Owner

yegle commented Aug 21, 2022

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants