Change to a proper exception

yegor256 · Jul 8, 2017 · 265c85b · 265c85b
1 parent 000ec5a
commit 265c85b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/src/main/java/org/cactoos/Bytes.java b/src/main/java/org/cactoos/Bytes.java
@@ -66,11 +66,15 @@ public NoNulls(final Bytes bytes) {
         @Override
         public byte[] asBytes() throws IOException {
             if (this.origin == null) {
-                throw new IOException("NULL instead of a valid bytes");
+                throw new IllegalArgumentException(
+                    "NULL instead of a valid bytes"
+                );
             }
             final byte[] bytes = this.origin.asBytes();
             if (bytes == null) {
-                throw new IOException("NULL instead of a valid byte array");
+                throw new IllegalStateException(
+                    "NULL instead of a valid byte array"
+                );
             }
             return bytes;
         }

diff --git a/src/test/java/org/cactoos/BytesTest.java b/src/test/java/org/cactoos/BytesTest.java
@@ -35,18 +35,18 @@
  */
 public final class BytesTest {
 
-    @Test(expected = IOException.class)
-    public void failForNullBytes() throws IOException {
+    @Test(expected = IllegalArgumentException.class)
+    public void failForNullArgument() throws IOException {
         new Bytes.NoNulls(null).asBytes();
     }
 
-    @Test(expected = IOException.class)
-    public void failForNullArray() throws IOException {
+    @Test(expected = IllegalStateException.class)
+    public void failForNullResult() throws IOException {
         new Bytes.NoNulls(() -> null).asBytes();
     }
 
     @Test
-    public void okForNoNullBytes() throws IOException {
+    public void okForNoNulls() throws IOException {
         new Bytes.NoNulls(() -> new byte[1]).asBytes();
     }
 }