New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken deployment, when Git doesn't have config #6

Closed
yegor256 opened this Issue Jul 24, 2014 · 8 comments

Comments

Projects
None yet
2 participants
@yegor256
Owner

yegor256 commented Jul 24, 2014

in version 1.5 we have a broken code. see this deployment, for example: https://travis-ci.org/yegor256/blog/builds/30760660

@yegor256

This comment has been minimized.

Show comment
Hide comment
@yegor256

yegor256 Jul 24, 2014

Owner

test added in 8564866

Owner

yegor256 commented Jul 24, 2014

test added in 8564866

yegor256 added a commit that referenced this issue Jul 24, 2014

yegor256 added a commit that referenced this issue Jul 24, 2014

yegor256 added a commit that referenced this issue Jul 24, 2014

@yegor256

This comment has been minimized.

Show comment
Hide comment
@yegor256

This comment has been minimized.

Show comment
Hide comment
@yegor256

yegor256 Jul 24, 2014

Owner

the problem is that

USER_EMAIL=$(git config --get user.email)

terminates the script because git exit code is 1 and we're using set -e

Owner

yegor256 commented Jul 24, 2014

the problem is that

USER_EMAIL=$(git config --get user.email)

terminates the script because git exit code is 1 and we're using set -e

@yegor256

This comment has been minimized.

Show comment
Hide comment
@yegor256

yegor256 Jul 24, 2014

Owner

@leucos do you want to pick this us? I reproduced the problem - Travis build is broken now. I'm not sure how to fix it properly though...

Owner

yegor256 commented Jul 24, 2014

@leucos do you want to pick this us? I reproduced the problem - Travis build is broken now. I'm not sure how to fix it properly though...

@yegor256

This comment has been minimized.

Show comment
Hide comment
@yegor256

yegor256 Jul 24, 2014

Owner

my best option is this:

USER_EMAIL=$(git config --get user.email | cat)

but it looks like a hack...

Owner

yegor256 commented Jul 24, 2014

my best option is this:

USER_EMAIL=$(git config --get user.email | cat)

but it looks like a hack...

yegor256 added a commit that referenced this issue Jul 24, 2014

yegor256 added a commit that referenced this issue Jul 24, 2014

yegor256 added a commit that referenced this issue Jul 24, 2014

@yegor256

This comment has been minimized.

Show comment
Hide comment
@yegor256

yegor256 Jul 24, 2014

Owner

@rultor release please, tag is 1.5.1

Owner

yegor256 commented Jul 24, 2014

@rultor release please, tag is 1.5.1

@rultor

This comment has been minimized.

Show comment
Hide comment
@rultor

rultor Jul 24, 2014

Collaborator

@rultor release please, tag is 1.5.1

@yegor256 OK, I will release it now. Please check the progress here

Collaborator

rultor commented Jul 24, 2014

@rultor release please, tag is 1.5.1

@yegor256 OK, I will release it now. Please check the progress here

@rultor

This comment has been minimized.

Show comment
Hide comment
@rultor

rultor Jul 24, 2014

Collaborator

@rultor release please, tag is 1.5.1

@yegor256 Done! FYI, the full log is here (took me 2min)

Collaborator

rultor commented Jul 24, 2014

@rultor release please, tag is 1.5.1

@yegor256 Done! FYI, the full log is here (took me 2min)

@yegor256 yegor256 closed this Jul 24, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment