New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handles additional config file #4

Merged
merged 4 commits into from Jul 24, 2014

Conversation

Projects
None yet
3 participants
@leucos
Contributor

leucos commented Jul 23, 2014

This patch adds the ability to add an additional config file.
The intended use is to have a different variable values for deployment.

The first use case is for the 'url' config variable. Creating an
additional _config-deploy.yml file with the deployment URL, one can
transparently use development and production URLs.

Handles additional config file
This patch adds the ability to add an additional config file.
The intended use is to have a different variable values for deployment.

The first use case is for the 'url' config variable. Creating an
additional _config-deploy.yml file with the deployment URL, one can
transparently use development and production URLs.
@yegor256

This comment has been minimized.

Show comment
Hide comment
@yegor256

yegor256 Jul 24, 2014

Owner

Looks good, but we should document this feature in README.md, otherwise nobody will know about it :)

Owner

yegor256 commented Jul 24, 2014

Looks good, but we should document this feature in README.md, otherwise nobody will know about it :)

leucos added some commits Jul 24, 2014

Adds documentation
Added documentation about the _config-deploy.yml feature
Added titles in README and a small blurb describing what is jgd for.
Typo
Fixed typo.
@leucos

This comment has been minimized.

Show comment
Hide comment
@leucos

leucos Jul 24, 2014

Contributor

Sure ! Here it is. I added few more things in the README, I hope that ok for you.

Contributor

leucos commented Jul 24, 2014

Sure ! Here it is. I added few more things in the README, I hope that ok for you.

Show outdated Hide outdated README.md
@@ -1,5 +1,16 @@
[![Gem Version](https://badge.fury.io/rb/jgd.svg)](http://badge.fury.io/rb/jgd)
# What is jqg ?

This comment has been minimized.

@yegor256

yegor256 Jul 24, 2014

Owner

typo here, should be jgd

@yegor256

yegor256 Jul 24, 2014

Owner

typo here, should be jgd

@yegor256

This comment has been minimized.

Show comment
Hide comment
@yegor256

yegor256 Jul 24, 2014

Owner

@leucos looks perfect, except one small typo, see above

Owner

yegor256 commented Jul 24, 2014

@leucos looks perfect, except one small typo, see above

Fixes another typo
Rule 1 : don't commit before coffee
@leucos

This comment has been minimized.

Show comment
Hide comment
@leucos

leucos Jul 24, 2014

Contributor

Ooops, sorry about that ! Fixed.

Contributor

leucos commented Jul 24, 2014

Ooops, sorry about that ! Fixed.

yegor256 added a commit that referenced this pull request Jul 24, 2014

Merge pull request #4 from leucos/deployment_config
Handles additional config file

@yegor256 yegor256 merged commit 5eb4c42 into yegor256:master Jul 24, 2014

@yegor256

This comment has been minimized.

Show comment
Hide comment
@yegor256

yegor256 Jul 24, 2014

Owner

@rultor release please, tag is 1.5

Owner

yegor256 commented Jul 24, 2014

@rultor release please, tag is 1.5

@rultor

This comment has been minimized.

Show comment
Hide comment
@rultor

rultor Jul 24, 2014

Collaborator

@rultor release please, tag is 1.5

@yegor256 OK, I will release it now. Please check the progress here

Collaborator

rultor commented Jul 24, 2014

@rultor release please, tag is 1.5

@yegor256 OK, I will release it now. Please check the progress here

@rultor

This comment has been minimized.

Show comment
Hide comment
@rultor

rultor Jul 24, 2014

Collaborator

@rultor release please, tag is 1.5

@yegor256 Done! FYI, the full log is here (took me 1min)

Collaborator

rultor commented Jul 24, 2014

@rultor release please, tag is 1.5

@yegor256 Done! FYI, the full log is here (took me 1min)

@yegor256

This comment has been minimized.

Show comment
Hide comment
@yegor256

yegor256 Jul 24, 2014

Owner

@leucos many thanks! your changes are in master already, and version 1.5 is in Rubygems :)

Owner

yegor256 commented Jul 24, 2014

@leucos many thanks! your changes are in master already, and version 1.5 is in Rubygems :)

@leucos

This comment has been minimized.

Show comment
Hide comment
@leucos

leucos Jul 24, 2014

Contributor

Awesome ! Many thanks for jgd btw ! And thanks to @rultor too :)

Contributor

leucos commented Jul 24, 2014

Awesome ! Many thanks for jgd btw ! And thanks to @rultor too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment