Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(#10): Throw Exception If javac Is Absent #15

Merged
merged 5 commits into from
Nov 24, 2023
Merged

feat(#10): Throw Exception If javac Is Absent #15

merged 5 commits into from
Nov 24, 2023

Conversation

volodya-lombrozo
Copy link
Contributor

Throw exception if javac binary wasn't found.

Closes: #10.

History:

@volodya-lombrozo
Copy link
Contributor Author

@yegor256 Could you take a look, please?

@volodya-lombrozo
Copy link
Contributor Author

@yegor256 Done. Could you take a look one more time, please?

@yegor256
Copy link
Owner

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Nov 24, 2023

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit dfe83c5 into yegor256:master Nov 24, 2023
14 checks passed
@rultor
Copy link
Collaborator

rultor commented Nov 24, 2023

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 3min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yegor256 yegor256 yegor256 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jhome.java:82-85: The javac binary might not be available...
3 participants
@volodya-lombrozo @yegor256 @rultor