From 58de2a9fd55487082691dc827791ca37320f2164 Mon Sep 17 00:00:00 2001 From: Polina Kopyrina Date: Tue, 5 Dec 2023 23:35:39 +0300 Subject: [PATCH] Remove stale 'todos' --- .../qulice/plugin/violations/Brackets.java | 4 --- .../com/qulice/plugin/violations/Pdd.java | 28 ------------------- .../it/checkstyle-violations/verify.groovy | 3 +- 3 files changed, 1 insertion(+), 34 deletions(-) delete mode 100644 qulice-maven-plugin/src/it/checkstyle-violations/src/main/java/com/qulice/plugin/violations/Pdd.java diff --git a/qulice-maven-plugin/src/it/checkstyle-violations/src/main/java/com/qulice/plugin/violations/Brackets.java b/qulice-maven-plugin/src/it/checkstyle-violations/src/main/java/com/qulice/plugin/violations/Brackets.java index 715dc5026..48de68470 100644 --- a/qulice-maven-plugin/src/it/checkstyle-violations/src/main/java/com/qulice/plugin/violations/Brackets.java +++ b/qulice-maven-plugin/src/it/checkstyle-violations/src/main/java/com/qulice/plugin/violations/Brackets.java @@ -38,8 +38,6 @@ public final class Brackets { /** * Simple method. - * @todo #123 Make this better - * in multiple lines but different. */ public void wrongBrackets() { new Foo(null, new int[]{1}, @@ -61,8 +59,6 @@ private void call(final String start, final String end) { /** * Check brackets structure. - * @todo #123 Make this better - * in multiple lines. */ private final class Foo { diff --git a/qulice-maven-plugin/src/it/checkstyle-violations/src/main/java/com/qulice/plugin/violations/Pdd.java b/qulice-maven-plugin/src/it/checkstyle-violations/src/main/java/com/qulice/plugin/violations/Pdd.java deleted file mode 100644 index 8f831b590..000000000 --- a/qulice-maven-plugin/src/it/checkstyle-violations/src/main/java/com/qulice/plugin/violations/Pdd.java +++ /dev/null @@ -1,28 +0,0 @@ -package com.qulice.plugin.violations; - -public class Pdd { - - /** - * Test. - * @todo #123:2h This is also valid. - */ - public void test() { - return; - } - - /** - * Test method. - * @todo #123? This is valid. - */ - public final void foreach() { - System.out.println("test"); - } - /** - * Test. - */ - public void inner() { - // @todo #123 Here we should capture - // also another line. - System.out.println("inner"); - } -} diff --git a/qulice-maven-plugin/src/it/checkstyle-violations/verify.groovy b/qulice-maven-plugin/src/it/checkstyle-violations/verify.groovy index b4ab62132..5ed773d83 100644 --- a/qulice-maven-plugin/src/it/checkstyle-violations/verify.groovy +++ b/qulice-maven-plugin/src/it/checkstyle-violations/verify.groovy @@ -38,14 +38,13 @@ assert log.text.contains('Tabs.java[4]: Line contains a tab character. (FileTabC assert log.text.contains('tabs.txt[1]: Line contains a tab character. (FileTabCharacterCheck)') assert log.text.findAll('Brackets.java.*(HeaderCheck)').empty //assert log.text.contains('Violations.java[6]: This method must be static, because it does not refer to "this"') -assert log.text.contains('Brackets.java[55]: Closing bracket should be on a new line (BracketsStructureCheck)') +assert log.text.contains('Brackets.java[53]: Closing bracket should be on a new line (BracketsStructureCheck)') assert log.text.contains('Violations.java[14]: Parameter txt should be final. (FinalParametersCheck)') assert log.text.contains('Violations.java[25]: Parameter ex should be final. (FinalParametersCheck)') assert log.text.contains('NewLines.java[4]: Lines in file should end with Unix-like end of line') assert log.text.contains('newlines.txt[3]: Lines in file should end with Unix-like end of line') assert log.text.contains('Violations.java[33]: ArrayList should be initialized with a size parameter') assert log.text.contains('Violations.java[34]: ArrayList should be initialized with a size parameter') -assert log.text.findAll('Pdd.java.*: .todo tag has wrong format').empty assert !log.text.contains('Got an exception - java.lang.NullPointerException') assert log.text.findAll('SomeTest.java .+ (JavadocMethodCheck)').isEmpty() assert !log.text.contains('IndentationChecks.java[19]: method call rparen at indentation level 12')