New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#190 Fixed resource leak when obtaining S3Object size #195

Merged
merged 2 commits into from Jul 22, 2014

Conversation

Projects
None yet
4 participants
@carlosmiranda
Collaborator

carlosmiranda commented Jul 22, 2014

It appears that when a client requests for an object's partial contents, another S3Object is obtained in order to get its full length so that it can be used in the Content-Range header data. However, this S3Object is not closed, which causes a connection leak, as each S3Object reference creates a connection to Amazon S3. See https://stackoverflow.com/questions/17782937/connectionpooltimeoutexception-when-iterating-objects-in-s3

This should address the error reported in #190.

@davvd

This comment has been minimized.

Show comment
Hide comment
@davvd

davvd Jul 22, 2014

Let me find a reviewer for this pull request, thanks for submitting it

davvd commented Jul 22, 2014

Let me find a reviewer for this pull request, thanks for submitting it

@davvd

This comment has been minimized.

Show comment
Hide comment
@davvd

davvd Jul 22, 2014

@yegor256 could you please review this PR

davvd commented Jul 22, 2014

@yegor256 could you please review this PR

@yegor256

This comment has been minimized.

Show comment
Hide comment
@yegor256
Owner

yegor256 commented Jul 22, 2014

@rultor merge

@rultor

This comment has been minimized.

Show comment
Hide comment
@rultor

rultor Jul 22, 2014

Collaborator

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

Collaborator

rultor commented Jul 22, 2014

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 67622ef into yegor256:master Jul 22, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build failed
Details
@rultor

This comment has been minimized.

Show comment
Hide comment
@rultor

rultor Jul 22, 2014

Collaborator

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 5min)

Collaborator

rultor commented Jul 22, 2014

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 5min)

@davvd

This comment has been minimized.

Show comment
Hide comment
@davvd

davvd Jul 24, 2014

@yegor256 Much obliged! I've added 16 mins to your account in payment "000-1a6b3592"

davvd commented Jul 24, 2014

@yegor256 Much obliged! I've added 16 mins to your account in payment "000-1a6b3592"

@davvd

This comment has been minimized.

Show comment
Hide comment
@davvd

davvd Jul 24, 2014

@rultor please deploy

davvd commented Jul 24, 2014

@rultor please deploy

@rultor

This comment has been minimized.

Show comment
Hide comment
@rultor

rultor Jul 24, 2014

Collaborator

@rultor please deploy

@davvd OK, I'll try to deploy now. You can check the progress here

Collaborator

rultor commented Jul 24, 2014

@rultor please deploy

@davvd OK, I'll try to deploy now. You can check the progress here

@rultor

This comment has been minimized.

Show comment
Hide comment
@rultor

rultor Jul 24, 2014

Collaborator

@rultor please deploy

@davvd Done! FYI, the full log is here (took me 21min)

Collaborator

rultor commented Jul 24, 2014

@rultor please deploy

@davvd Done! FYI, the full log is here (took me 21min)

@carlosmiranda carlosmiranda deleted the carlosmiranda:190 branch Jul 28, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment