New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default outline: 0 #173

Merged
merged 1 commit into from Dec 26, 2018

Conversation

Projects
None yet
4 participants
@SaraVieira
Copy link
Contributor

SaraVieira commented Dec 26, 2018

Many thanks for your contribution, we truly appreciate it. We will appreciate it even more, if you make sure that you can say "YES" to each point in this short checklist:

  • You made a small amount of changes (less than 100 lines, less than 10 files)
  • You made changes related to only one bug (create separate PRs for separate problems)
  • You are ready to defend your changes (there will be a code review)
  • You don't touch what you don't understand
  • You ran the build locally and it passed

This article will help you understand what we are looking for: http://www.yegor256.com/2015/02/09/serious-code-reviewer.html

Thank you for your contribution!


Hello,

Having an outline of 0 makes the links and buttons unusable by keyboard and creates huge problems with accessibility

http://www.outlinenone.com/

Remove default outline: 0
Hello,

Having an outline of 0 makes the links and buttons unusable by keyboard and creates huge problems with accessibility

http://www.outlinenone.com/
@0crat

This comment has been minimized.

Copy link

0crat commented Dec 26, 2018

@filfreire/z please, pay attention to this pull request

@0crat

This comment has been minimized.

Copy link

0crat commented Dec 26, 2018

@SaraVieira this pull request is too small, just 1 lines changed (less than 10), there will be no formal code review, see §53 and §28; in the future, try to make sure your pull requests are not too small; @filfreire/z please review this and merge or reject

@filfreire filfreire self-requested a review Dec 26, 2018

@filfreire

This comment has been minimized.

Copy link
Collaborator

filfreire commented Dec 26, 2018

@rultor merge

@rultor

This comment has been minimized.

Copy link
Collaborator

rultor commented Dec 26, 2018

@rultor merge

@filfreire OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 61cdd03 into yegor256:master Dec 26, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rultor

This comment has been minimized.

Copy link
Collaborator

rultor commented Dec 26, 2018

@rultor merge

@filfreire Done! FYI, the full log is here (took me 3min)

@filfreire

This comment has been minimized.

Copy link
Collaborator

filfreire commented Dec 26, 2018

@rultor release, tag is 1.3.6

@rultor

This comment has been minimized.

Copy link
Collaborator

rultor commented Dec 26, 2018

@rultor release, tag is 1.3.6

@filfreire OK, I will release it now. Please check the progress here

@rultor

This comment has been minimized.

Copy link
Collaborator

rultor commented Dec 26, 2018

@rultor release, tag is 1.3.6

@filfreire Done! FYI, the full log is here (took me 3min)

@filfreire

This comment has been minimized.

Copy link
Collaborator

filfreire commented Dec 26, 2018

@0crat

This comment has been minimized.

Copy link

0crat commented Dec 26, 2018

Job gh:yegor256/tacit#173 is not assigned, can't get performer

@0crat

This comment has been minimized.

Copy link

0crat commented Dec 26, 2018

This job is not in scope

@SaraVieira

This comment has been minimized.

Copy link
Contributor Author

SaraVieira commented Dec 26, 2018

Thank you :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment