Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failed on windows with lots of EOL violations #148

Closed
longtimeago opened this issue Apr 7, 2015 · 17 comments
Closed

Build failed on windows with lots of EOL violations #148

longtimeago opened this issue Apr 7, 2015 · 17 comments

Comments

@longtimeago
Copy link

Looks like we need to add .gitattributes to force EOL of the repo.
See how it was done here https://github.com/jcabi/jcabi-aether/pull/59/files

@yegor256 yegor256 added the bug label Apr 7, 2015
@YamStranger
Copy link
Contributor

@davvd Its great idea!!! (as here #128)

@davvd
Copy link

davvd commented Apr 7, 2015

we will find someone to do this task, soon

@davvd
Copy link

davvd commented Apr 7, 2015

@YamStranger please pick this up, and keep in mind these instructions. Any technical questions - ask right here... Budget here is 30 mins (keep this principle in mind)

@davvd
Copy link

davvd commented Apr 7, 2015

@longtimeago thank you for the ticket reported, I topped your account for 15 mins, transaction 55000221

@YamStranger
Copy link
Contributor

@davvd Thanks, I take it.

YamStranger added a commit to YamStranger/takes that referenced this issue Apr 7, 2015
YamStranger added a commit to YamStranger/takes that referenced this issue Apr 7, 2015
@YamStranger
Copy link
Contributor

@davvd fix in pull request #156. Please look at it

This was referenced Apr 10, 2015
@YamStranger
Copy link
Contributor

@davvd As I see pull request #156 merged long time ago, but this issue is still open. Is some problem with it?

@longtimeago
Copy link
Author

@YamStranger sorry for that. It's the responsibility of issue reporter to close it and I missed that event. Don't hesitate to ping the issue reporter in such case :)

@davvd
Copy link

davvd commented Apr 18, 2015

@elenavolokhova please, review this ticket for compliance with our QA rules

@elenavolokhova
Copy link

@YamStranger

YamStranger commented 12 days ago
Its great idea!!! (as here #128)

davvd commented 12 days ago
we will find someone to do this task, soon

According to our quality rules:

Messages in a ticket always start with a name of a user they are addressed to.

As far as you are the performer of this ticket you are responsible for its quality. Please make sure that everyone follows this rule in your tickets in the future. Ask them to fix issues before closing the ticket.

Please confirm that everything is clear and you have no questions regarding this approach.

@longtimeago
Copy link
Author

@elenavolokhova everything is clear

@elenavolokhova
Copy link

@longtimeago Thank you, but this one is not yours :)

@YamStranger
Copy link
Contributor

@elenavolokhova fixed, thanks

@elenavolokhova
Copy link

@davvd Ticket passed QA review. Quality is acceptable.

@davvd
Copy link

davvd commented Apr 20, 2015

@davvd Ticket passed QA review. Quality is acceptable.

@elenavolokhova thanks for the QA review, we'll work better next time

@YamStranger
Copy link
Contributor

@davvd please share details of payment for this issue

@davvd
Copy link

davvd commented Apr 24, 2015

@YamStranger 10 mins was added to the account of @elenavolokhova (for QA review), in transaction 55988887... thank you, added 38 mins to your acc, payment num is 55988911, 184 hours and 28 mins spent in total to complete... there is a bonus for fast delivery (age=2915)... added +38 to your rating, now it is equal to +174

This was referenced Jun 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants