Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TkRetry #430

Closed
yegor256 opened this issue Nov 4, 2015 · 24 comments
Closed

TkRetry #430

yegor256 opened this issue Nov 4, 2015 · 24 comments

Comments

@yegor256
Copy link
Owner

@yegor256 yegor256 commented Nov 4, 2015

Let's create a new decorator TkRetry, which will not fail immediately on IOException, but will retry a few times:

new TkRetry(
  original_take,
  3, // how many times to retry, maximum
  30 // initial delay between retries, in milliseconds
);
@davvd
Copy link

@davvd davvd commented Nov 4, 2015

@yegor256 I added bug tag to this ticket

@davvd davvd added the bug label Nov 4, 2015
@davvd
Copy link

@davvd davvd commented Nov 4, 2015

@yegor256 I set the milestone to 1.0 since there is nothing set yet

@davvd davvd added this to the 1.0 milestone Nov 4, 2015
@davvd
Copy link

@davvd davvd commented Nov 4, 2015

@yegor256 many thanks, 15 mins added to your acc for reporting this bug, pmt ID 000-1e62e95a

@davvd
Copy link

@davvd davvd commented Dec 10, 2015

@aschworer This task is yours, please go ahead keeping in mind this. If any questions, don't hesitate to ask right here; 30 mins is the budget of the task. This is exactly how much will be paid when the problem is solved (no matter how much time you will actually spend). See this for more information

@aschworer
Copy link

@aschworer aschworer commented Dec 16, 2015

@davvd i've created a pull request, please review

@davvd
Copy link

@davvd davvd commented Dec 16, 2015

@davvd i've created a pull request, please review

@aschworer thanks

aschworer added a commit to aschworer/takes that referenced this issue Dec 19, 2015
@davvd
Copy link

@davvd davvd commented Dec 25, 2015

@aschworer you're holding this ticket for 15 days already. If it is not finished (and closed) in the next 48 hours, it will be re-assigned to someone else, see No Obligations principle (this article should help if you're stuck); -30 to your rating, your total score is -30

aschworer added a commit to aschworer/takes that referenced this issue Dec 25, 2015
aschworer added a commit to aschworer/takes that referenced this issue Dec 25, 2015
aschworer added a commit to aschworer/takes that referenced this issue Dec 25, 2015
aschworer added a commit to aschworer/takes that referenced this issue Dec 25, 2015
aschworer added a commit to aschworer/takes that referenced this issue Dec 25, 2015
@aschworer
Copy link

@aschworer aschworer commented Dec 27, 2015

@davvd It's been 34 hours we are waiting for the merge confirm from @yegor256 (pull request #472).

@davvd
Copy link

@davvd davvd commented Dec 30, 2015

@davvd It's been 34 hours we are waiting for the merge confirm from @yegor256 (pull request #472).

@aschworer it doesn't really matter, check this: http://at.teamed.io/policy.html#7 If you can't complete your task in time, inform me, see http://at.teamed.io/policy.html#10

@davvd
Copy link

@davvd davvd commented Dec 30, 2015

@aschworer you've been working with this task for too long. I'm sorry, but I'll assign someone else. Please stop working with it. See our no obligations principle; added -60 to your rating, now it is equal to -90

@davvd davvd removed the @aschworer label Dec 30, 2015
@davvd
Copy link

@davvd davvd commented Dec 31, 2015

@HDouss the task is yours, please go ahead

@davvd davvd added the @hdouss label Dec 31, 2015
HDouss added a commit to HDouss/takes that referenced this issue Dec 31, 2015
@HDouss HDouss mentioned this issue Dec 31, 2015
@aschworer
Copy link

@aschworer aschworer commented Jan 1, 2016

@davvd it is done and waiting for merge confirm for the past 7 days

@HDouss
Copy link
Contributor

@HDouss HDouss commented Jan 3, 2016

@davvd PR #493 reviewed and ready for merge. We wait for the architect to confirm the merge here.

@davvd
Copy link

@davvd davvd commented Jan 3, 2016

@davvd it is done and waiting for merge confirm for the past 7 days

@aschworer the task is "done" when it's closed by its author. this task is not done. when @yegor256 closes it, I will consider it done. see http://www.yegor256.com/2014/11/24/principles-of-bug-tracking.html

HDouss added a commit to HDouss/takes that referenced this issue Jan 4, 2016
HDouss added a commit to HDouss/takes that referenced this issue Jan 4, 2016
HDouss added a commit to HDouss/takes that referenced this issue Jan 4, 2016
HDouss added a commit to HDouss/takes that referenced this issue Jan 5, 2016
HDouss added a commit to HDouss/takes that referenced this issue Jan 5, 2016
Conflicts:
	src/main/java/org/takes/tk/TkRetry.java
HDouss added a commit to HDouss/takes that referenced this issue Jan 5, 2016
HDouss added a commit to HDouss/takes that referenced this issue Jan 5, 2016
HDouss added a commit to HDouss/takes that referenced this issue Jan 5, 2016
HDouss added a commit to HDouss/takes that referenced this issue Jan 6, 2016
HDouss added a commit to HDouss/takes that referenced this issue Jan 6, 2016
HDouss added a commit to HDouss/takes that referenced this issue Jan 7, 2016
@HDouss
Copy link
Contributor

@HDouss HDouss commented Jan 8, 2016

@yegor256 PR #493 reviewed and merged. Please close the issue.

@yegor256
Copy link
Owner Author

@yegor256 yegor256 commented Jan 8, 2016

@HDouss thanks!

@yegor256 yegor256 closed this Jan 8, 2016
@yegor256
Copy link
Owner Author

@yegor256 yegor256 commented Jan 8, 2016

@rultor release, tag is 0.30

@rultor
Copy link
Collaborator

@rultor rultor commented Jan 8, 2016

@rultor release, tag is 0.30

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Collaborator

@rultor rultor commented Jan 8, 2016

@rultor release, tag is 0.30

@yegor256 Done! FYI, the full log is here (took me 1hr)

@HDouss
Copy link
Contributor

@HDouss HDouss commented Jan 9, 2016

@davvd Issue closed.

@davvd
Copy link

@davvd davvd commented Jan 10, 2016

@ypshenychka please, review this task for compliance with our quality rules

@ypshenychka
Copy link

@ypshenychka ypshenychka commented Jan 10, 2016

@davvd Quality is good.

@davvd
Copy link

@davvd davvd commented Jan 10, 2016

@davvd Quality is good.

@ypshenychka thanks a lot :)

@davvd
Copy link

@davvd davvd commented Jan 10, 2016

@HDouss just added 10 mins to @ypshenychka (for QA), payment ID is 74105723. Much appreciated! 30 mins was added to your account, payment ID 74105742, time spent is 211 hours and 6 mins. +30 to your rating, your total score is +804

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants