4 MB is the new 1 MB is the new 64 sectors #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Align disk/image to 4 MiB for mkboot and growimg, taking into account sector size. This is especially important for cheap flash (see background). - Ramdisk and openbsd.vnd remain untouched with 0 and 64 offsets, respectively. - Tested mkboot on i386 and amd64. - Personal note: I've been using this on manually-configured OpenBSD and Linux for years without issue. Background: - https://lwn.net/Articles/428584/ (see Partitioning, Future work, and comments re: alignment) - https://lists.gnu.org/archive/html/bug-parted/2013-01/msg00000.html
|
Respun for mkboot and growimg. I don't use growimg and don't have available hardware to test it right now, but it seems likely to be correct. |
yellowman
added a commit
that referenced
this pull request
Apr 24, 2015
4 MB is the new 1 MB is the new 64 sectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: