Proposal: Drop minsafe option and templates #452

Closed
eddiemonge opened this Issue Nov 13, 2013 · 10 comments

Comments

Projects
None yet
6 participants
Member

eddiemonge commented Nov 13, 2013

Since the project is built using ngmin in grunt, does it make sense to still have min-safe and minsafe templates? They add complexity to the code and if removed would make maintaining and testing easier.

👍

Member

eddiemonge commented Dec 4, 2013

Owner

sindresorhus commented Dec 4, 2013

From what I can remember they're there because ngmin was quite unstable. Not sure if that still applies.

Member

eddiemonge commented Dec 4, 2013

I would love to rip that out if no one has an objection. Granted, if people rely on minsafe because they created a project not using ngmin then the generator no longer will work for them. But for those people, updating to use ngmin could be a documentation update issue. Really, who wants to write all their code like ['name', function(name){}]. Ugh so ugly. Let it be done in the background.

Member

passy commented Dec 4, 2013

+1

Even though ngmin has some edge cases it doesn't cover at the moment, you can still manually work around them. The minsafe branch complicates the code a lot and is a big maintenance burden that very few people actually benefit from.

e-oz commented Dec 5, 2013

as addicted user of generator-angular, I ask you to not make me type additional option each time.
I thought programming is (also) about automation of repeating actions, so it would be "un-automation".

Contributor

btford commented Dec 5, 2013

I'm personally for removing it.

Member

eddiemonge commented Dec 5, 2013

@jamm This would be getting rid of something that requires you to type additional stuff and automates it for you.

Deprecate in the next point release and remove in the one after that then? Any opposed?

Member

passy commented Dec 5, 2013

sgtm
On Dec 5, 2013 4:42 PM, "Eddie Monge" notifications@github.com wrote:

@jamm https://github.com/jamm This would be getting rid of something
that requires you to type additional stuff and automates it for you.

Deprecate in the next point release and remove in the one after that then?
Any opposed?


Reply to this email directly or view it on GitHubhttps://github.com/yeoman/generator-angular/issues/452#issuecomment-29913915
.

eddiemonge added a commit to eddiemonge/generator-angular that referenced this issue Dec 6, 2013

feat(gen): add welcome message and dep notice for minsafe
Adds a Yeoman welcome message. Add a deprecation notice for the minsafe
option.

Closes #452

eddiemonge added a commit to eddiemonge/generator-angular that referenced this issue Dec 7, 2013

feat(gen): add welcome message and dep notice for minsafe
Adds a Yeoman welcome message. Add a deprecation notice for the minsafe
option.

Closes #452

eddiemonge added a commit to eddiemonge/generator-angular that referenced this issue Dec 7, 2013

feat(gen): add welcome message and dep notice for minsafe
Adds a Yeoman welcome message. Add a deprecation notice for the minsafe
option.

Closes #452

@addyosmani addyosmani closed this in #489 Dec 8, 2013

Contributor

btford commented Dec 9, 2013

👏

eddiemonge added a commit to eddiemonge/generator-angular that referenced this issue Jan 27, 2014

feat(app): remove minsafe options
Remove the minsafe templates, documentation and options from the
generator.

Closes #452

BREAKING CHANGE: Removes the --minsafe from the generator. See the
readme for more information about this change

eddiemonge added a commit to eddiemonge/generator-angular that referenced this issue Jan 27, 2014

feat(app): remove minsafe options
Remove the minsafe templates, documentation and options from the
generator.

Closes #452

BREAKING CHANGE: Removes the --minsafe from the generator. See the
readme for more information about this change

eddiemonge added a commit to eddiemonge/generator-angular that referenced this issue Jan 27, 2014

feat(app): remove minsafe options
Remove the minsafe templates, documentation and options from the
generator.

Closes #452

BREAKING CHANGE: Removes the --minsafe from the generator. See the
readme for more information about this change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment