fixes #378 404 main css, main.js #391

Merged
merged 2 commits into from Mar 26, 2016

Projects

None yet

2 participants

@mteodori
Contributor

incorrect generated app name in main when a dash is used

@ruyadorno ruyadorno and 1 other commented on an outdated diff Mar 25, 2016
generators/app/index.js
@@ -163,7 +163,7 @@ var BackboneGenerator = yeoman.generators.Base.extend({
this.destinationPath('.jshintrc'),
{
appName: this.appname,
- appSlugName: paramCase(this.appname),
+ appSlugName: pascalCase(this.appname),
@ruyadorno
ruyadorno Mar 25, 2016 Member

the name appSlugName was just used because it referred to a different module we were using here at first, now that you're on it, it would be actually nice to replace it to something that makes more sense, maybe appPascalCaseName ?

we need to change both here and in the jshintrc template file 😊

@mteodori
mteodori Mar 25, 2016 Contributor

ok for me, didn't know about the history behind the variable name :)

@ruyadorno
Member

👍 great!

many thanks for all the awesome PRs 🎉

@ruyadorno ruyadorno merged commit bc001b6 into yeoman:master Mar 26, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mteodori mteodori deleted the mteodori:issue-378 branch Mar 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment