compose with generator-travis

[iamstarkov]

I found composeWith feature as awesome one and think that if yeoman community will have smaller generators then, everybody will benefit from it. For example with this pull-request, generator-node will no longer need to handle travis config on its own. What do you think?

[SBoudrias]

LGTM!

I just want to take a look at the travis generator before actually merging. I'll try to get back to you before the weekend.

[arthurvr]

Don't change the indentation here please :)

[arthurvr]

LGTM. Thanks!

Although it works for our use case, I think the generator-travis misses a bunch of things. It would be cool if it had options like what node versions to use, if people even want node at all, custom commands, ... Without those things it's useless for a bunch of generators out there.

[SBoudrias]

I have the same question as @arthurvr here, what is the plan for the future of this generator?

[iamstarkov]

what is the plan for the future of this generator?

It is really good question. I spend few days on thinking how to keep balance between single responsibility and extensibility.

Initial idea was to have easy way to get travis config with up to date node versions, like yo travis. Main improvement I can see is to extend existing travis config, (right now it is overriding every time).

I can easily support all the other fields, but I feel like it will blur purpose of this generator. If someone want to have other scripts in travis config, maybe its the job for generator-coveralls or smth. So this generator will only handle node versions and keep already existing fields as before, while other generators will be able to make their job. What do you think?

PS. the reason why I add nodejs as default env, because nodejs community is almost the only yeoman consumer.

PS 2. This Semver upgrade model seems good enough:

1. Patch versions will be updated when generator is about to get small code fixes, or going to remove old node versions.
2. Minor version will be updated, when generator will get new node versions in the list.
3. Major versions will be updated, when generator will get breaking change for generator-consumers

[iamstarkov]

Second thought is to support all custom fields, because then everybody still can use up-to-date node versions and just extend travis config. So right now roadmap looks like this: 1. extend travis config 2. support all custom fields. What do you think?

[iamstarkov]

Delivered with generator-travis 1.1. Will add tests for extend logic as well

[iamstarkov]

only one problem I found, fields in result travis config is not sorted properly. For example:

writing: function () {
  this.composeWith('travis', { options: {
    config: { after_script: 'npm run coveralls' }
  }}, {
    local: require.resolve('generator-travis/generators/app')
  });
},

Will be:

after_script: 'npm run coveralls'
language: node_js
node_js:
  - stable
  - iojs
  - '0.12'
  - '0.10'

Is there any way to sorted JSON.stringify?

[iamstarkov]

Yay, I imlemented sorted Yaml config and added tests. Take a look pls.

[iamstarkov]

I’m also thinking to add feature of removing old node versions from the list, because whole point is to get "up-to-date" travis config, it will be true by default with possibility to turn off in options or with flag.

So what do you think about pull-request?

[iamstarkov]

@SBoudrias @arthurvr looking for your feedback =)

[SBoudrias]

I’m also thinking to add feature of removing old node versions from the list, because whole point is to get "up-to-date" travis config, it will be true by default with possibility to turn off in options or with flag.

IMO, I'd settle on a default config (0.10, 0.12, stable) and allow an option to manually specify versions. I'd be simpler.

It's kind of important currently supporting 0.10 to 4.1 because apt-get default is still 0.10, so a lot of people still have it installed.

---

For this CR, I'm okay to merge. But fix the indentation issue and update the readme too as there's references to the travis sub-generator.

[iamstarkov]

• fixed indentation /cc @arthurvr
• update generator-node readme /cc @SBoudrias
• add ability to specify nodejs versions in the config options /cc @SBoudrias

Also I wanted the more clear way to understand how to add or remove versions in the list, so I found nodejs/LTS plan and ended up relevant section in the generator-travis’s readme. generator-travis seems to be finished. What do you think?

[SBoudrias]

Cool, LGTM.

Please squash your commits and we'll merge.

[iamstarkov]

done

[SBoudrias]

Here it goes! Thanks a ton

[hemanth]

👍

@iamstarkov I understand have dependencies is good thing, but would it be more cleaner if this lands in as travis with all the other generators ?

Say if someone wants to fiddle with travis generator, will land to the generators dir and wonders where the generator is and then realises it's from require.resolve('generator-travis/generators/app') and then has to do a PR to that generator....

//cc @SBoudrias