Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Can the bundle task be removed? #27

Closed
jonkemp opened this Issue Feb 24, 2014 · 2 comments

Comments

Projects
None yet
1 participant
Contributor

jonkemp commented Feb 24, 2014

I'm considering having gulp-useref just call gulp-bundle internally. This would get rid of the bundle task, which would mean that the scripts and styles prerequisite tasks would move to the html task. It would also simplify a lot of the gulp-bundle code and make gulp-useref more similar to grunt-useref.

The biggest question I have is does having gulp-useref call gulp-bundle internally to handle the file concatenation violate the 'each gulp plugin should only do one thing' principle. Even if that is the case, it seems like it's duplicating a lot of code just to get around that restriction.

Contributor

jonkemp commented Mar 6, 2014

I am working on updating gulp-useref so that it will handle the concatenation of the assets itself, instead of requiring gulp-bundle. The assets will then be pushed onto the stream and passed on. Gulp-filter could be used to do any asset modification after that. I think this works better than requiring another task and another dependency.

You can see my work here.

https://github.com/jonkemp/gulp-useref/tree/useref2

I would like to get some feedback before I publish it. Once the new version is published, I can submit a pull request here. Thanks!

Contributor

jonkemp commented Mar 14, 2014

5a6ae82 closes

@jonkemp jonkemp closed this Mar 14, 2014

SBoudrias pushed a commit that referenced this issue Feb 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment