CSS tasks are broken when sass is disabled #40

Closed
denver25 opened this Issue Mar 15, 2014 · 3 comments

Comments

Projects
None yet
3 participants

There is no alternative code for if Sass is not included, which means that unless you use sass,

  • the styles task is missing, thus
  • autoprefixer functionality is missing
  • the clean task doesn't touch files in dist/styles
  • the watch task doesn't watch for .css files
  • the <!-- bower:css --> block is missing in index.html, thus
  • wiredep functionality is missing
  • the <!-- build:css --> block is missing in index.html, thus
  • dependency CSS will not be built into dist
  • styles are not built into the dist directory

This leaves the generator partially broken if you choose not to use Sass. I looked back at the history and the changes were introduced in commit 1f3ec4e and have been published already in 0.0.4.

Just a thought: I don't know enough about node.js testing and yeoman generators to know if this is possible, but a functional test may be good for preventing big bugs like this in the future. It could scaffold a simple app, build it, and then check what actually appeared in the dist directory.

Looks like test.js does something similar right now to check that the scaffolding step works.

Owner

addyosmani commented Mar 15, 2014

Thanks for catching this. We're going to need to improve on the unit tests for this generator if we're to catch regressions like this. Looping in @jrcryer in case he has time to put together a fix for the issue we introduced after merging in the last set of sass changes.

Contributor

jrcryer commented Mar 15, 2014

Sure assign it over to me - see if I can get a some tests in around this later today and patch it.

jrcryer added a commit to jrcryer/generator-gulp-webapp that referenced this issue Mar 16, 2014

Fixes #40 - Add tasks in for no Sass include
Signed-off-by: James Cryer <info@jamescryer.com>

jrcryer added a commit to jrcryer/generator-gulp-webapp that referenced this issue Mar 16, 2014

jrcryer added a commit to jrcryer/generator-gulp-webapp that referenced this issue Mar 16, 2014

addyosmani added a commit that referenced this issue Mar 22, 2014

Merge pull request #42 from jrcryer/no-sass-include
Fixes #40 - Add support for styles task when sass not included
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment