New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Sass built-in error logging #242

Merged
merged 1 commit into from Dec 15, 2014

Conversation

Projects
None yet
2 participants
@silvenon
Member

silvenon commented Dec 15, 2014

No description provided.

@@ -10,7 +10,8 @@ gulp.task('styles', function () {<% if (includeSass) { %>
.pipe($.rubySass({
style: 'expanded',
precision: 10
}))<% } else { %>
}))
.on('error', function(err) { console.log(err.message); })<% } else { %>

This comment has been minimized.

@sindresorhus

sindresorhus Dec 15, 2014

Member

.on('error', console.error.bind(console));

@silvenon

This comment has been minimized.

Member

silvenon commented Dec 15, 2014

Done, but this prints out errors like this:

{ [Error: error main.scss (Line 7: Invalid CSS after "@import ": expected file to import (string or url()), was "blah;")]
  message: 'error main.scss (Line 7: Invalid CSS after "@import ": expected file to import (string or url()), was "blah;")',
  showStack: false,
  showProperties: true,
  plugin: 'gulp-ruby-sass',
  __safety: { toString: [Function] } }

Did you want that?

@sindresorhus

This comment has been minimized.

Member

sindresorhus commented Dec 15, 2014

@silvenon Yeah, looks like a bug with gulp-util: gulpjs/gulp-util#74 Just do it as you did before for now.

@silvenon

This comment has been minimized.

Member

silvenon commented Dec 15, 2014

Done. Should I also paint it red with chalk.js?

sindresorhus added a commit that referenced this pull request Dec 15, 2014

Merge pull request #242 from yeoman/plumber
Use Sass built-in error logging

@sindresorhus sindresorhus merged commit bb6070f into master Dec 15, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@silvenon silvenon deleted the plumber branch Dec 15, 2014

@sindresorhus

This comment has been minimized.

Member

sindresorhus commented Dec 15, 2014

Nah, it's fine.

SBoudrias pushed a commit that referenced this pull request Feb 15, 2016

Update grunt-usemin to stop creating broken links
🎶 You can't play on broken links... 🎶

Fixes #242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment