New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the Base generator to find non-enumerable methods #769

Merged
merged 1 commit into from Mar 3, 2015

Conversation

Projects
None yet
3 participants
@jamesallardice
Contributor

jamesallardice commented Mar 3, 2015

This adds the possibility of writing generators with ES2015 class
syntax. Fixes #767.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 3, 2015

Coverage Status

Coverage increased (+0.0%) to 97.43% when pulling d54c933 on jamesallardice:support-class-syntax into 3f1c783 on yeoman:master.

coveralls commented Mar 3, 2015

Coverage Status

Coverage increased (+0.0%) to 97.43% when pulling d54c933 on jamesallardice:support-class-syntax into 3f1c783 on yeoman:master.

Show outdated Hide outdated test/base.js Outdated
Allow the Base generator to find non-enumerable methods
This adds the possibility of writing generators with ES2015 class
syntax. Fixes #767.
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 3, 2015

Coverage Status

Coverage increased (+0.0%) to 97.43% when pulling 1eb889a on jamesallardice:support-class-syntax into 3f1c783 on yeoman:master.

coveralls commented Mar 3, 2015

Coverage Status

Coverage increased (+0.0%) to 97.43% when pulling 1eb889a on jamesallardice:support-class-syntax into 3f1c783 on yeoman:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 3, 2015

Coverage Status

Coverage increased (+0.0%) to 97.43% when pulling 1eb889a on jamesallardice:support-class-syntax into 3f1c783 on yeoman:master.

coveralls commented Mar 3, 2015

Coverage Status

Coverage increased (+0.0%) to 97.43% when pulling 1eb889a on jamesallardice:support-class-syntax into 3f1c783 on yeoman:master.

SBoudrias added a commit that referenced this pull request Mar 3, 2015

Merge pull request #769 from jamesallardice/support-class-syntax
Allow the Base generator to find non-enumerable methods

@SBoudrias SBoudrias merged commit 124dcc3 into yeoman:master Mar 3, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0%) to 97.43%
Details
@SBoudrias

This comment has been minimized.

Show comment
Hide comment
@SBoudrias

SBoudrias Mar 3, 2015

Member

Perfect! Thanks a lot!

I'll make a release later today.

Member

SBoudrias commented Mar 3, 2015

Perfect! Thanks a lot!

I'll make a release later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment