Fix undefined boolean options - Fix #988 #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mischah
reviewed
Dec 19, 2016
| @@ -20,6 +20,8 @@ var Storage = require('./util/storage'); | |||
| var promptSuggestion = require('./util/prompt-suggestion'); | |||
| var debug = require('debug')('yeoman:generator'); | |||
|
|
|||
| var EMPTY = '@@_YEOMAN_EMPTY_MARKER_@@'; | |||
There was a problem hiding this comment.
What’s '@@_YEOMAN_EMPTY_MARKER_@@'? 😳
There was a problem hiding this comment.
I need a way to detect if an explicit value was passed or not. I though of using a Symbol given it'd be a guaranteed unique value, but minimist breaks if default is not a string or a number.
So, I went with a long string that hopefully won't collide with any real value
SBoudrias
force-pushed
the
fix/undefined-options
branch
from
8e7048e
to
23732e9
Compare
|
Okay, I'll merge as is (now with regression test) to unbreak 1.0 :) |
|
😘 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got to add and fix tests. But here's a first draft to tackle the bug.