Skip to content

Fix grammar and typos #160

Merged
merged 2 commits into from Apr 29, 2014

5 participants

@robertd
robertd commented Feb 26, 2014

Cheers!!

@robwierzbowski robwierzbowski and 1 other commented on an outdated diff Feb 26, 2014
app/_includes/yeoman.wiki/docs/Generators.md
@@ -30,7 +30,7 @@ _And a day of good to you, sir._
When developing a generator, having the option to "do this else that" based on the response of the user creates a whole new world of possibilities. You can conditionally fetch dependencies, create files, tests, configuration files for various tools (EditorConfig, git, JSHint), and anything else you dream up.
-Working with the terminal, worrying about spawning concurrent processes, creating race conditions, and other concerns you may have about the Node enviroment have been taken care of. Even for the unfamiliar, it's super easy to get started writing your own generator.
+Working with the terminal, worrying about spawning concurrent processes, creating race conditions and other concerns you may have about the Node environment have been taken care of. Even for the unfamiliar, it's super easy to get started writing your own generator.

Oxford comma, acceptable when there is more than two list parts. I would keep.

oxford comma

(although obviously I would rather invite stripper JFK and Stalin to my party)

@robertd
robertd added a note Feb 27, 2014

LMAO!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@robwierzbowski robwierzbowski commented on an outdated diff Feb 26, 2014
app/_includes/yeoman.wiki/docs/Generators.md
@@ -117,7 +117,7 @@ You'll probably want to see what you're creating and play with it while still de
~ npm link
```
-Because `generator-blog` was specified as the package name in `package.json`, `npm link` will create a symbolic link in a more widely-accessible location (e.g., `/usr/local/lib/node_modules/generator-blog`). This enables you to access your local `~/dev/generator-blog` generator globally, making development, and life in general, much easier.
+Because `generator-blog` was specified as the package name in `package.json`, `npm link` will create a symbolic link in a more widely-accessible location (e.g., `/usr/local/lib/node_modules/generator-blog`). This enables you to access your local `~/dev/generator-blog` generator globally, making development and life in general, much easier.

Oxford again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@robwierzbowski robwierzbowski commented on an outdated diff Feb 26, 2014
app/_includes/yeoman.wiki/docs/Generators.md
@@ -138,7 +138,7 @@ Switch over to a new tab, create a new folder, and see what you get!
Would you like to enable this option? (Y/n)
```
-There he is again with his silly questions. Play around for a bit, then come back when you're ready for a walkthrough of what's happening behind the scenes.
+There he is again with his silly questions. Play around for a bit, and then come back when you're ready for a walkthrough of what's happening behind the scenes.

Just one, so ++, would remove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@robwierzbowski robwierzbowski commented on an outdated diff Feb 26, 2014
app/_includes/yeoman.wiki/docs/Generators.md
@@ -168,7 +168,7 @@ var prompts = [{
}];
```
-Next, you'll see something you'll start seeing a lot more of-- magic. Helper methods given to you from the Yeoman Generator itself.
+Next, you'll see something you'll start seeing a lot more of-- magic. Helper methods given to you by the Yeoman Generator itself.

As long as we're going crazy on comma removal, we can take out the one after Next, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@robwierzbowski robwierzbowski commented on an outdated diff Feb 26, 2014
app/_includes/yeoman.wiki/docs/Generators.md
@@ -298,7 +298,7 @@ Note:
<h2 id="okay-huddle-up">Okay, huddle up.</h2>
-Let's review what we're trying to do real quick, to make sure we're on the same page.
+Let's review what we're trying to do really quick, to make sure we're on the same page.

Let's take out the adverbs and extra description all together. "Let's review what we're trying to do."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@robwierzbowski

Sweet!

@eddiemonge eddiemonge removed their assignment Feb 26, 2014
@robertd
robertd commented Mar 1, 2014

@robwierzbowski How does this look now?

@addyosmani
Yeoman member

This would need to be rebased a little as we've recently done a bit of a reorg on the content structure.

@eddiemonge
Yeoman member

@robertd if you can rebase your changes, we can get this in.

@robertd
robertd commented Apr 29, 2014

Rebased and squashed

@eddiemonge eddiemonge commented on an outdated diff Apr 29, 2014
app/generators.md
@@ -173,7 +173,7 @@ var prompts = [{
}];
```
-Next, you'll see something you'll start seeing a lot more of-- magic. Helper methods given to you from the Yeoman Generator itself.
+Next you'll see something you'll start seeing a lot more of-- magic. Helper methods given to you by the Yeoman Generator itself.
@eddiemonge
Yeoman member
eddiemonge added a note Apr 29, 2014

maybe colon or long dash instead of -- and should be a space after of in of-- is its not a colon. Sorry, didnt see that one before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@robertd
robertd commented Apr 29, 2014

Let me know how this looks and then I'll squash them.

@eddiemonge eddiemonge merged commit 7762c3d into yeoman:master Apr 29, 2014

1 check failed

Details continuous-integration/travis-ci The Travis CI build failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.