Permalink
Browse files

Adds temp fix for bower install, updates tests which were strict chec…

…king based on bower list to check on dir creation instead, minor change to changelog.
  • Loading branch information...
1 parent eb9123a commit 79683a1bb037c9dffb4a85040a0ca96bb023735b @addyosmani addyosmani committed Oct 2, 2012
Showing with 25 additions and 3 deletions.
  1. +9 −0 changelog.md
  2. +5 −2 cli/tasks/bower.js
  3. +11 −1 cli/test/test-bower.js
View
@@ -1,3 +1,12 @@
+
+### 0.9.3 (3 October, 2012)
+
+* Temporary fix to allow Bower dependencies to be correctly copied to app/components. As a result of this patch RequireJS wiring of Bower deps is currently disabled
+
+### 0.9.2
+
+TBU
+
### 0.9.1 (15 September, 2012)
* Removal of stdout checks, test against fs (Pull [#473](https://github.com/yeoman/yeoman/pull/473)).
View
@@ -41,13 +41,16 @@ module.exports = function(grunt) {
.on('error', grunt.fatal.bind(grunt.fail))
.on('data', grunt.log.writeln.bind(grunt.log))
.on('end', function(){
+
+ grunt.helper('bower:sync', directory, cb);
+ /*
if(args[0] === 'install' && directory) {
- grunt.helper('bower:copy', directory, cb);
+ grunt.helper('bower:sync', directory, cb);
} else if(args[0] === 'uninstall' || args[0] === 'update' && directory) {
grunt.helper('bower:sync', directory, cb);
} else {
cb();
- }
+ }*/
});
});
@@ -7,7 +7,7 @@ var fs = require('fs'),
bower = require('bower').commands;
// bower components to test out
-var components = ['jquery', 'backbone'];
+var components = ['jquery', 'backbone', 'spine'];
// var components = ['jquery', 'backbone', 'ember', 'angular', 'canjs'];
describe('Bower install packages', function() {
@@ -43,15 +43,25 @@ describe('Bower install packages', function() {
it('should have copied resolved components to app/components', function(done) {
var ctx = this;
+
+ fs.stat(path.join('app/components', name), done);
+
+ /*
bower.list({ map: true })
.on('error', done)
.on('data', function(results) {
+
ctx.results = results;
var pkg = results[name];
+
var source = ctx[name] = pkg.source.main;
var vendor = source.replace(/^components/, 'app/components');
fs.stat(vendor, done);
+
+
});
+
+ */
});
});

0 comments on commit 79683a1

Please sign in to comment.