Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from grunt-requirejs to grunt-contrib-requirejs #1050

Closed
sindresorhus opened this issue May 12, 2013 · 4 comments
Closed

Switch from grunt-requirejs to grunt-contrib-requirejs #1050

sindresorhus opened this issue May 12, 2013 · 4 comments

Comments

@sindresorhus
Copy link
Member

Author of grunt-requirejs is unresponsive and the task is huge and buggy. We also don't really need any of the extra stuff.

https://github.com/asciidisco/grunt-requirejs
https://github.com/gruntjs/grunt-contrib-requirejs

@kevva @passy can you think of any reason not to do this?

@passy
Copy link
Member

passy commented May 12, 2013

I'm not too familiar with the tasks, but grunt-requirejs seems to have a lot of features that the contrib version doesn't have yet. If we don't use it though, we should probably switch.

@sindresorhus
Copy link
Member Author

Most of what it provides extra should really be separate tasks, and I'm sure there already are by someone else. Since it's just grunt people are free to switch if they need any of it, but as default it should be something light and maintained.

@sindresorhus sindresorhus mentioned this issue May 12, 2013
9 tasks
@addyosmani
Copy link
Member

@sindresorhus is the only change required for this switching out the deps we're pulling in or is there more to it than that? I would be tempted to ask on @yeoman if anyone is opposed to the change as I feel we don't (yet) have a good feel for what task features our RequireJS users care about.

@sindresorhus
Copy link
Member Author

@addyosmani they don't lose anything of RequireJS, just some useless stuff like being able to change r.js version. It's already switched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants