New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alias `grunt serve` for ultimate grammar correctness #1183

Closed
robwierzbowski opened this Issue Sep 10, 2013 · 14 comments

Comments

Projects
None yet
7 participants
@robwierzbowski

robwierzbowski commented Sep 10, 2013

The grammarian in me wants both build and server commands to be verbs, for consistency's sake. Jekyll just made the same switch, and will eventually deprecate server. What do you think about switching to grunt serve, and aliasing server to it until the next major release?

@sindresorhus

This comment has been minimized.

Show comment
Hide comment
@sindresorhus
Member

sindresorhus commented Sep 10, 2013

👍

@passy

This comment has been minimized.

Show comment
Hide comment
@passy

passy Sep 10, 2013

Member

I thought that many times before. If we agreed on doing that we could use the got way of deprecating things. Add the other option as alias, then add a deprecation warning for the old one and at some point in the future remove the old option.

Member

passy commented Sep 10, 2013

I thought that many times before. If we agreed on doing that we could use the got way of deprecating things. Add the other option as alias, then add a deprecation warning for the old one and at some point in the future remove the old option.

@robwierzbowski

This comment has been minimized.

Show comment
Hide comment
@robwierzbowski

robwierzbowski Sep 10, 2013

@passy Exactly.

Millions less 'r's typed around the globe. I'll send a PR.

robwierzbowski commented Sep 10, 2013

@passy Exactly.

Millions less 'r's typed around the globe. I'll send a PR.

@addyosmani

This comment has been minimized.

Show comment
Hide comment
@addyosmani

addyosmani Sep 25, 2013

Member

👍

Member

addyosmani commented Sep 25, 2013

👍

@passy

This comment has been minimized.

Show comment
Hide comment
@ivanoats

This comment has been minimized.

Show comment
Hide comment
@ivanoats

ivanoats Sep 30, 2013

Let's just make this an explicit 👍 ... thanks @passy 😄

ivanoats commented Sep 30, 2013

Let's just make this an explicit 👍 ... thanks @passy 😄

@robwierzbowski

This comment has been minimized.

Show comment
Hide comment
@robwierzbowski

robwierzbowski Oct 27, 2013

PR'd to webapp!

robwierzbowski commented Oct 27, 2013

PR'd to webapp!

@sindresorhus

This comment has been minimized.

Show comment
Hide comment
@sindresorhus

sindresorhus Nov 6, 2013

Member

Now it's just all our other generators left. Go go :p

Member

sindresorhus commented Nov 6, 2013

Now it's just all our other generators left. Go go :p

thomas-lebeau added a commit to thomas-lebeau/generator-bootstrap-less that referenced this issue Nov 14, 2013

@addyosmani

This comment has been minimized.

Show comment
Hide comment
@addyosmani

addyosmani Jan 9, 2014

Member

We've started deprecating server in favor of serve across a number of generators. Let's check which ones are left now that it's been 2 months since we started on this :)

Member

addyosmani commented Jan 9, 2014

We've started deprecating server in favor of serve across a number of generators. Let's check which ones are left now that it's been 2 months since we started on this :)

@eddiemonge

This comment has been minimized.

Show comment
Hide comment
@eddiemonge

eddiemonge Jan 14, 2014

Member

none are left. all official generators have been PR'ed. Didn't want to be to presumptuous and merge them all.

Member

eddiemonge commented Jan 14, 2014

none are left. all official generators have been PR'ed. Didn't want to be to presumptuous and merge them all.

@sindresorhus

This comment has been minimized.

Show comment
Hide comment
@sindresorhus

sindresorhus Jan 14, 2014

Member

@eddiemonge awesome! thanks for doing this 💃

Member

sindresorhus commented Jan 14, 2014

@eddiemonge awesome! thanks for doing this 💃

@robwierzbowski

This comment has been minimized.

Show comment
Hide comment
@robwierzbowski

robwierzbowski commented Jan 14, 2014

😺 💥

@safjanowski

This comment has been minimized.

Show comment
Hide comment
@safjanowski

safjanowski Jan 16, 2014

There left some nouns to change: jshint » check, mocha » test, jasmine » test, coffee » makeCoffe, compass » compile, imagemin » minimalizeImageSize. For all of them the same rule – make them verbs

safjanowski commented Jan 16, 2014

There left some nouns to change: jshint » check, mocha » test, jasmine » test, coffee » makeCoffe, compass » compile, imagemin » minimalizeImageSize. For all of them the same rule – make them verbs

@robwierzbowski

This comment has been minimized.

Show comment
Hide comment
@robwierzbowski

robwierzbowski Jan 16, 2014

I think the individual targets tend to refer to their alias or destination (:serve targets are used in grunt serve, :test in grunt test, :dist targets in grunt build [?!]).

I'm not sure makeCoffee / compile gives a good description of what the targets do, since for example all Compass targets will compile Sass. But maybe we can revisit the groupings:

  1. What's up with dist? If it refers to the folder, why is the folder templated to be switchable?
  2. Do we name targets by alias / larger task they belong to? If so, what should we call a target used in serve and build tasks?

robwierzbowski commented Jan 16, 2014

I think the individual targets tend to refer to their alias or destination (:serve targets are used in grunt serve, :test in grunt test, :dist targets in grunt build [?!]).

I'm not sure makeCoffee / compile gives a good description of what the targets do, since for example all Compass targets will compile Sass. But maybe we can revisit the groupings:

  1. What's up with dist? If it refers to the folder, why is the folder templated to be switchable?
  2. Do we name targets by alias / larger task they belong to? If so, what should we call a target used in serve and build tasks?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment