Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Cannot have blank line in usemin blocks #560

Closed
juggy opened this Issue · 1 comment

2 participants

@juggy

If you group your scripts tag with blank lines in you index.html, the usemin task will not parse the scripts line correctly. The min and concat config are then empty. Subsequent tasks fails.

To reproduce:

  • Create a usemin block
  • add a couple of scripts and separate them by blank lines
  • run yeoman build
@sleeper
Owner

Actually, adding a blank line to a block even break the build:


Running "usemin-handler:html" (usemin-handler) task
Going through index.html to update the config
looking for build script HTML comment blocks
<WARN> Cannot call method 'split' of undefined Use --force to continue. </WARN>

@sleeper sleeper referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@sleeper sleeper referenced this issue
Merged

Fix issue #560 #563

@sleeper sleeper referenced this issue from a commit in sleeper/yeoman
@sleeper sleeper Fix issue #560 and #565
Treat the case of empty lines in blocks (#560)
as well as the filename collision (#565)
e41faba
@sleeper sleeper referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@sleeper sleeper referenced this issue from a commit in sleeper/yeoman
@sleeper sleeper Fix issue #560 and #565
Treat the case of empty lines in blocks (#560)
as well as the filename collision (#565)
45c9d02
@sleeper sleeper closed this
@szinya szinya referenced this issue from a commit in menthainternet/yeoman
@sleeper sleeper Fix issue #560 and #565
Treat the case of empty lines in blocks (#560)
as well as the filename collision (#565)
bdc24e4
@sleeper sleeper referenced this issue from a commit
@sleeper sleeper Fix issue #560 and #565
Treat the case of empty lines in blocks (#560)
as well as the filename collision (#565)
b407be9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.