Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Verify Insight properly creates directory structure on Windows. #579

Closed
ebidel opened this Issue · 14 comments

4 participants

@ebidel
Owner

These need to map to the same dir:
https://github.com/yeoman/yeoman/blob/master/cli/lib/plugins/insight.js#L12
https://github.com/yeoman/yeoman/blob/master/cli/bin/yeomaninsight.py#L21

Verify they do on Windows. Otherwise, insight will continue to prompt.

@ebidel ebidel was assigned
@addyosmani
Owner

I had a number of developers run into this issue on Windows during my workshop (reprompting). Would be great if we could fix.

@brenelz

Anyone have a fix here for making it so insight doesn't always popup on windows?

@brenelz

Seems like creating a .log in C:\Users\USERNAME.yeoman\insight\ folder stops the error. Problem is nothing is getting logged to the file tho...

@addyosmani
Owner

Speaking to developers in the community, this specific issue is causing a lot of Windows devs trouble. I'd like to include an initial solution to it in 0.9.4, which we might try to release this Friday.

@ebidel I understand and appreciate how important Insight tracking is to the project :) At the same time, this specific issue means Yeoman is unusable for anything more than a quick playaround for Windows devs.

Would you mind us implementing the flag we discussed to skip insights for contributors which we would also (for now) recommend Windows users use to make Yeoman work for them? We would aim to provide a proper fix for this issue in 0.9.5 or 0.9.6

@ebidel
Owner

We don't official support Windows yet. Users shouldn't expect things to work 100%.

Let's keep the dev flag a separate issue (#385) from this. I'm going to try to knock both of these out today.

@addyosmani
Owner

sgtm

@sindresorhus

Just a reminder. Release tomorrow.

@ebidel
Owner

Im debugging this as we speak. Took 1/2 day to reformat our Windows machine.

@ebidel
Owner

Ok Windows is a PITA. I can't use child_process.spawn. No idea why. It just doesn't work on Windows.
I'm looking into using child_process.exec instead, but it involves reworking some structure :\

@ebidel ebidel referenced this issue from a commit
@ebidel ebidel - Addresses #579
- insight picks up help command
- Fixed issue where insight no longer reported states in "yeoman" was run without args
4c9ffed
@ebidel
Owner

Tested pretty thoroughly but can someone please review to make sure I didn't massively break everything?

@ebidel
Owner

BTW, I need to verify this works on Windows still. From my testing today, exec() does the trick, but I've also re-factored some core code here.

@sindresorhus

+9999 on the Windows PITA thing. We're only supporting it because of demand...

Changes seems fine just from looking at them.

Btw, you might have run into this bug: https://gist.github.com/3427148

@ebidel
Owner

Thanks @sindresorhus. I don't do std IO in the .py script anymore. Not sure what it was,...but it wasn't fun.

@ebidel
Owner

Verified working on windows.

@ebidel ebidel closed this
@szinya szinya referenced this issue from a commit in menthainternet/yeoman
@ebidel ebidel - Addresses #579
- insight picks up help command
- Fixed issue where insight no longer reported states in "yeoman" was run without args
594483c
@ebidel ebidel referenced this issue from a commit
@ebidel ebidel - Addresses #579
- insight picks up help command
- Fixed issue where insight no longer reported states in "yeoman" was run without args
f4ffdef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.