Usemin:css inserts invalid <link> element #586

Closed
oxyc opened this Issue Oct 5, 2012 · 2 comments

Comments

Projects
None yet
2 participants

oxyc commented Oct 5, 2012

There's a small typo in the usemin logic where some regexp is used in a replacement string.

content.replace(block, indent + '<link rel="stylesheet" href="' + target + '"\/?>');

This consequently breaks the revving of css files as the element wont be matched.

It should instead be:

content.replace(block, indent + '<link rel="stylesheet" href="' + target + '"/>');

[L311]

Contributor

sleeper commented Oct 5, 2012

OK. I'm going to fix it as part of the other usemin related fixes (namely #560 and #565)

@ghost ghost assigned sleeper Oct 5, 2012

sleeper added a commit to sleeper/yeoman that referenced this issue Oct 5, 2012

@sleeper sleeper referenced this issue Oct 5, 2012

Merged

Fix issue #560 #563

Contributor

sleeper commented Oct 5, 2012

Fixed in PR #563.

@oxyc Thanks for the analysis and findings !

sleeper added a commit that referenced this issue Oct 6, 2012

@sleeper sleeper closed this Oct 6, 2012

szinya pushed a commit to menthainternet/yeoman that referenced this issue Sep 17, 2014

szinya pushed a commit to menthainternet/yeoman that referenced this issue Sep 17, 2014

sleeper added a commit that referenced this issue Apr 24, 2015

sleeper added a commit that referenced this issue Apr 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment