Skip to content
This repository

Usemin:css inserts invalid <link> element #586

Closed
oxyc opened this Issue · 2 comments

2 participants

Oskar Schöldström Frederick Ros
Oskar Schöldström

There's a small typo in the usemin logic where some regexp is used in a replacement string.

content.replace(block, indent + '<link rel="stylesheet" href="' + target + '"\/?>');

This consequently breaks the revving of css files as the element wont be matched.

It should instead be:

content.replace(block, indent + '<link rel="stylesheet" href="' + target + '"/>');

[L311]

Frederick Ros
Collaborator

OK. I'm going to fix it as part of the other usemin related fixes (namely #560 and #565)

Frederick Ros sleeper referenced this issue from a commit in sleeper/yeoman
Frederick Ros Fixing #586 a88b0fe
Frederick Ros
Collaborator

Fixed in PR #563.

@oxyc Thanks for the analysis and findings !

Frederick Ros sleeper closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.