Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

"Cheerio!" is the wrong thing to say :) #770

Closed
vishvish opened this Issue Dec 5, 2012 · 12 comments

Comments

Projects
None yet
8 participants

vishvish commented Dec 5, 2012

It's a little thing, but it's doing my head in, as a Londoner. "Cheerio" means goodbye, and seeing it as a default greeting when the yeoman server fires up makes me cry. It's completely out of context and couldn't be more wrong if it wrongly fell out of the wrong tree onto the wrong person.

Shout me down if you like, it's just a bit grating to see it :)

Owner

sindresorhus commented Dec 5, 2012

PR welcome :)

How about 'Allo, 'Allo? A stereotypical cockney greeting ;-)

Rydgel commented Dec 5, 2012

What about “Bonjour” 🇫🇷

staabm commented Dec 5, 2012

"Hellas" ?

Member

hemanth commented Dec 5, 2012

How about location based greeting? 🔎

Rydgel commented Dec 5, 2012

@hemanth “à la Flickr?”

Member

hemanth commented Dec 5, 2012

@Rydgel heh heh kina ;) <h1>{{ APP.title }}</h1> in metrics/templates/base.html must be set based on the location. Pinch of angular.js.

@sindresorhus ^ seems fine?

vishvish commented Dec 5, 2012

In the spirit of Eastenders, perhaps, "Allo, Treacle"?

vishvish commented Dec 5, 2012

Or South London style: "Yo, man!"

Contributor

btford commented Jan 24, 2013

This also needs to be done for index.html files in each individual generator (or at least the ones that used H5BP as a starting point).

@btford btford referenced this issue in yeoman/generator-angular Jan 24, 2013

Merged

Update greeting #14

@sindresorhus sindresorhus added a commit to yeoman/generator-webapp_DEPRECATED that referenced this issue Jan 30, 2013

@sindresorhus sindresorhus Update greeting in index.html d7fa8ea
Owner

sindresorhus commented Jan 30, 2013

I've updated the rest. Closing.

@TimvdEijnden TimvdEijnden pushed a commit to TimvdEijnden/generator-webapp_requirejs that referenced this issue Jan 29, 2014

@sindresorhus sindresorhus Update greeting in index.html eeef650
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment