Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to mocha from jasmine by default. #187

Merged
merged 3 commits into from Aug 8, 2012
Merged

Switch to mocha from jasmine by default. #187

merged 3 commits into from Aug 8, 2012

Conversation

paulmillr
Copy link
Contributor

seems to be easy. maybe i'm missing something?

  1. New tests are working when I run test/index.html.
  2. New tests are working when I run phantomJS.

@addyosmani
Copy link
Member

Thanks for the PR! :) I've just reviewed the changes and they look absolutely fine to me.

Before we merge, @mklabs is there anything else we need to/wanted to change to bring in mocha support? This swaps out Jasmine in the app and simpleapp generator to use mocha instead and we could easily merge if theres nothing else pending.

@paulmillr
Copy link
Contributor Author

awesome

@sindresorhus
Copy link
Member

Should probably change test Run a Jasmine test harness in a headless Phantom.js (bin/help.txt) in the CLI and any other references to Jasmine.

@paulmillr
Copy link
Contributor Author

done.

@sindresorhus
Copy link
Member

The sample app todos_spine_requirejs is using Jasmine, and should probably also be converted. Wdyt Addy?

@addyosmani
Copy link
Member

@sindresorhus agreed. The app also needs to be updated to use the latest version of yeoman (including our updated directory structure). I'll redo the whole thing sometime this week.

@addyosmani
Copy link
Member

@paulmillr thanks for the rest of the updates. We should be able to land this tomorrow.

@mklabs
Copy link
Contributor

mklabs commented Aug 8, 2012

Before we merge, @mklabs is there anything else we need to/wanted to change to bring in mocha support?

Sounds good to me. Tests have been updated as well \o/ Thanks a lot @paulmillr !

addyosmani added a commit that referenced this pull request Aug 8, 2012
Switch to mocha from jasmine by default.
@addyosmani addyosmani merged commit 0c14cb7 into yeoman:master Aug 8, 2012
@paulirish
Copy link
Member

This is most good!

💞

Thank you!

addyosmani added a commit that referenced this pull request Apr 24, 2015
Switch to mocha from jasmine by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants