New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to mocha from jasmine by default. #187
Conversation
|
Thanks for the PR! :) I've just reviewed the changes and they look absolutely fine to me. Before we merge, @mklabs is there anything else we need to/wanted to change to bring in mocha support? This swaps out Jasmine in the app and simpleapp generator to use mocha instead and we could easily merge if theres nothing else pending. |
|
awesome |
|
Should probably change |
|
done. |
|
The sample app |
|
@sindresorhus agreed. The app also needs to be updated to use the latest version of yeoman (including our updated directory structure). I'll redo the whole thing sometime this week. |
|
@paulmillr thanks for the rest of the updates. We should be able to land this tomorrow. |
Sounds good to me. Tests have been updated as well \o/ Thanks a lot @paulmillr ! |
Switch to mocha from jasmine by default.
|
This is most good! Thank you! |
Switch to mocha from jasmine by default.
seems to be easy. maybe i'm missing something?
test/index.html.