Join GitHub today
support for serving php files #270
Nice work! Some interesting refactoring going on there :)
Thanks, I'm glad you like it.
About your last concern: The only PHP-specific part ist the mapping from the file-extension to the name of the CGI interpreter. Everything else RFC 3875 which is completely language agnostic. A good idea would probably be to put these mappings into the Gruntfile so that developers can add their own.
About the size of the new dependencies: Both new modules tamper and gateway don't have any further external dependencies and consist of only one single file. The largest part of both modules are their unit tests ;)
BTW, the tamper test-suite checks if the server behaves in the same way with and without the middleware in place (even for large files). But I absolutely agree that we should thoroughly test that this doesn't break anything.
I applaud and appreciate the effort, but this is IMHO a bad idea.
If you intent is to be able to use yeoman server for its livereload ability, you should rely on the livereload extensions and avoid the need of any script injection. You can then use any kind of HTTP server, you'll just need to start yeoman server without using it as an HTTP server, just for the file watch and notification to livereload.js
To be able to establish the connection, you'll need to force the port to 35729 in the Gruntfile config, with
I've tested it on a dummy wordpress install and now using it extensively at work on a symfony project.
Just a heads up.
I landed this
We're going to use grunt-contrib-connect in the future, so this will make it possible for users to easily hook in this PHP as a middleware.
I'm going to close this for now, but will definitely reopen if we decide to include support for PHP when we explore back-end support.