Insight tests

[gnuwilliam]

Adding tests for Insight. Was already closed, but not merged.

// @paulirish

[addyosmani]

Looks good. Silly question - is there a reason the test-insight file is empty?

[addyosmani]

Looks good. Silly question - is there a reason the test-insight file is empty?

[gnuwilliam]

@addyosmani This is just a personal pattern that I use for commits. Baby-steps, always. Even creating a file, I do a commit. If you need to revert, or change something, you'll see all the changes, step-by-step on your git log. :-)

[gnuwilliam]

@addyosmani This is just a personal pattern that I use for commits. Baby-steps, always. Even creating a file, I do a commit. If you need to revert, or change something, you'll see all the changes, step-by-step on your git log. :-)

[sindresorhus]

@gnuwilliam git isn't cmd+s u know :P

Can you merge down the commits? We (I, I guess) prefer having a clean commit history.

But looks good to me otherwise.

[sindresorhus]

@gnuwilliam git isn't cmd+s u know :P

Can you merge down the commits? We (I, I guess) prefer having a clean commit history.

But looks good to me otherwise.

[gnuwilliam]

@sindresorhus Hahaha, you know I have some git troubles. :-P

Anyway, done! I did merged the commits.

Thanks!

[gnuwilliam]

@sindresorhus Hahaha, you know I have some git troubles. :-P

Anyway, done! I did merged the commits.

Thanks!

[gnuwilliam]

@ebidel Hi Eric. Could you please review the tests? Then we can close the PR.

[gnuwilliam]

@ebidel Hi Eric. Could you please review the tests? Then we can close the PR.

[ebidel]

LGTM

[ebidel]

LGTM