Insight tests #509

Merged
merged 1 commit into from Sep 23, 2012

Conversation

Projects
None yet
4 participants
@gnuwilliam
Contributor

gnuwilliam commented Sep 20, 2012

Adding tests for Insight. Was already closed, but not merged.

// @paulirish

@addyosmani

This comment has been minimized.

Show comment Hide comment
@addyosmani

addyosmani Sep 20, 2012

Owner

Looks good. Silly question - is there a reason the test-insight file is empty?

Owner

addyosmani commented Sep 20, 2012

Looks good. Silly question - is there a reason the test-insight file is empty?

@gnuwilliam

This comment has been minimized.

Show comment Hide comment
@gnuwilliam

gnuwilliam Sep 20, 2012

Contributor

@addyosmani This is just a personal pattern that I use for commits. Baby-steps, always. Even creating a file, I do a commit. If you need to revert, or change something, you'll see all the changes, step-by-step on your git log. :-)

Contributor

gnuwilliam commented Sep 20, 2012

@addyosmani This is just a personal pattern that I use for commits. Baby-steps, always. Even creating a file, I do a commit. If you need to revert, or change something, you'll see all the changes, step-by-step on your git log. :-)

@sindresorhus

This comment has been minimized.

Show comment Hide comment
@sindresorhus

sindresorhus Sep 20, 2012

Owner

@gnuwilliam git isn't cmd+s u know :P

Can you merge down the commits? We (I, I guess) prefer having a clean commit history.

But looks good to me otherwise.

Owner

sindresorhus commented Sep 20, 2012

@gnuwilliam git isn't cmd+s u know :P

Can you merge down the commits? We (I, I guess) prefer having a clean commit history.

But looks good to me otherwise.

Adding test-insight file
Creating test for tracking code

Raising exception when no tracking_code is passed

Creating test for main
@gnuwilliam

This comment has been minimized.

Show comment Hide comment
@gnuwilliam

gnuwilliam Sep 20, 2012

Contributor

@sindresorhus Hahaha, you know I have some git troubles. :-P

Anyway, done! I did merged the commits.

Thanks!

Contributor

gnuwilliam commented Sep 20, 2012

@sindresorhus Hahaha, you know I have some git troubles. :-P

Anyway, done! I did merged the commits.

Thanks!

@gnuwilliam

This comment has been minimized.

Show comment Hide comment
@gnuwilliam

gnuwilliam Sep 23, 2012

Contributor

@ebidel Hi Eric. Could you please review the tests? Then we can close the PR.

Contributor

gnuwilliam commented Sep 23, 2012

@ebidel Hi Eric. Could you please review the tests? Then we can close the PR.

@ebidel

This comment has been minimized.

Show comment Hide comment
@ebidel

ebidel Sep 23, 2012

Member

LGTM

Member

ebidel commented Sep 23, 2012

LGTM

ebidel added a commit that referenced this pull request Sep 23, 2012

@ebidel ebidel merged commit 2558702 into yeoman:master Sep 23, 2012

szinya pushed a commit to menthainternet/yeoman that referenced this pull request Sep 17, 2014

ebidel added a commit that referenced this pull request Apr 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment