Update cli/tasks/server.js #712

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@lildemon

what this line does?

@paulirish
Yeoman member

u srs, bro?

@sindresorhus
Yeoman member

It makes yeoman server run both our server task and the grunt watch task.

@lildemon

but this line does exactly nothing,
First it define grunt.registerTask('server', 'yeoman-server watch')
Then the following grunt.registerTask('server', 'Launch a preview, LiveReload compatible server', function(target) immediately override it
plus I couldn't find any task called 'yeoman-server' because it registered nowhere!?

@lildemon

please inform me if I was wrong , thanks :P

@lildemon

Im guessing you guys was gonna define
grunt.registerTask('yeoman-server', 'Launch a preview, LiveReload compatible server', function(target)
if it was, theres a bug

@sindresorhus
Yeoman member

You're right, it does nothing, was made moot in e3bf291#L0R194

But please, in the future, use your words.

@paulirish
Yeoman member

📚 🎆

@lildemon

Sorry, English isn't my main language. no offence, I think those words I expressed sounds not polite

:|

@sindresorhus sindresorhus added a commit that referenced this pull request Nov 13, 2012
@sindresorhus sindresorhus Remove moot registerTask. Fixes #712
It's being overridden anyway.
79e74f1
@sindresorhus sindresorhus added a commit that referenced this pull request Apr 24, 2015
@sindresorhus sindresorhus Remove moot registerTask. Fixes #712
It's being overridden anyway.
89701cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment