Skip to content
This repository

Update cli/tasks/server.js #712

Closed
wants to merge 1 commit into from

3 participants

lildemon Paul Irish Sindre Sorhus
lildemon

what this line does?

Paul Irish
Owner

u srs, bro?

Sindre Sorhus

It makes yeoman server run both our server task and the grunt watch task.

Sindre Sorhus sindresorhus closed this November 13, 2012
lildemon

but this line does exactly nothing,
First it define grunt.registerTask('server', 'yeoman-server watch')
Then the following grunt.registerTask('server', 'Launch a preview, LiveReload compatible server', function(target) immediately override it
plus I couldn't find any task called 'yeoman-server' because it registered nowhere!?

lildemon

please inform me if I was wrong , thanks :P

lildemon

Im guessing you guys was gonna define
grunt.registerTask('yeoman-server', 'Launch a preview, LiveReload compatible server', function(target)
if it was, theres a bug

Sindre Sorhus

You're right, it does nothing, was made moot in e3bf291#L0R194

But please, in the future, use your words.

Paul Irish
Owner

:books::fireworks:

lildemon

Sorry, English isn't my main language. no offence, I think those words I expressed sounds not polite

:|

Sindre Sorhus sindresorhus referenced this pull request from a commit November 13, 2012
Sindre Sorhus Remove moot registerTask. Fixes #712
It's being overridden anyway.
79e74f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Nov 13, 2012
lildemon Update cli/tasks/server.js
what this line does?
9fc109d
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 1 addition and 2 deletions. Show diff stats Hide diff stats

  1. 3  cli/tasks/server.js
3  cli/tasks/server.js
... ...
@@ -1,4 +1,3 @@
1  
-
2 1
 var fs = require('fs'),
3 2
   path = require('path'),
4 3
   util = require('util'),
@@ -171,7 +170,7 @@ module.exports = function(grunt) {
171 170
 
172 171
   // The server task always run with the watch task, this is done by
173 172
   // aliasing the server task to the relevant set of task to run.
174  
-  grunt.registerTask('server', 'yeoman-server watch');
  173
+  //grunt.registerTask('server', 'yeoman-server watch');
175 174
 
176 175
   // Reload handlers
177 176
   // ---------------
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.