You can clone with
Stick to providing a CLI wrapper tool rather than bundling an arbitrary set of opinionated generators with this tool. This should be like grunt-cli and not blur the boundaries.
generator-mocha, however, is required by lots of other generators. I wouldn't remove the dependency from yo until we have a robust solution for peer dependencies.
Was asked to cc @paulirish
+1 however I would want us to better expose what our officially supported generators are on the site prior to this change being made.
Inspired by @passy, I think the use of peerDependencies would allow us to remove generator-mocha and instead add it to the generators that depend on it. This field has been supported since npm 1.2.0. I'm willing to help with this if you want me to submit some PRs.
For #19 - removes bundled generators
@danielmcormond Would be great if you could look into that and verify that it works as expected.
Ok, I believe it's working as expected. Here's an example using Addy's non-bundled-generator branch of yo, and my branch of generator-webapp which requires generator-mocha as a peer dependency.
$ npm install -g https://nodeload.github.com/addyosmani/yo/tar.gz/nobundle
$ npm install -g https://nodeload.github.com/danielmcormond/generator-webapp/tar.gz/peer-dependencies
If you like this, I can add pull requests for whatever other generators currently rely on generator-mocha.
Just let me know!
@danielmcormond I like it and thanks for putting together the peerDependencies PR for generator-karma as well. If you have time would you like to look at PRs for other generators which also have a similar dependency?
Yes, I'd be happy to! I just need a little help:
Being a newcomer to the Yeoman generator scene, I'm not exactly sure which generators are depending on generator-mocha. A quick ack of all the generators within the yeoman org doesn't show anything directly depending on generator-mocha via a npm dependency.
So I'm assuming the dependency is somehow indirect or inferred? If someone can point me in the right direction about how to determine which generators need generator-mocha, I'll happily submit PRs for all of them.
@danielmcormond you just need to check them manually in the index.js if they hookFor test-framework.
Remove bundled generators