From 30ae16d093b80b78f866f687ed8ce5b59f6259b8 Mon Sep 17 00:00:00 2001 From: clement Date: Fri, 25 Jun 2021 11:43:10 +0200 Subject: [PATCH] fix: Change comment node type to "Block" to match spaced-comment eslint rule prerequisites --- packages/eslint-plugin/lib/rules/utils/node-utils.js | 2 +- packages/eslint-plugin/lib/types.d.ts | 2 +- packages/parser/lib/postprocessor/postprocessor.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/eslint-plugin/lib/rules/utils/node-utils.js b/packages/eslint-plugin/lib/rules/utils/node-utils.js index a280c9be..119df222 100644 --- a/packages/eslint-plugin/lib/rules/utils/node-utils.js +++ b/packages/eslint-plugin/lib/rules/utils/node-utils.js @@ -55,6 +55,6 @@ module.exports = { * @returns {node is CommentNode} `true` if a node is `CommentNode`, otherwise `false`. */ isCommentNode(node) { - return !!(node && node.type === "comment"); + return !!(node && node.type === "Block"); }, }; diff --git a/packages/eslint-plugin/lib/types.d.ts b/packages/eslint-plugin/lib/types.d.ts index 78d3dc12..0c9bb115 100644 --- a/packages/eslint-plugin/lib/types.d.ts +++ b/packages/eslint-plugin/lib/types.d.ts @@ -104,7 +104,7 @@ export interface AttrNode extends BaseNode { } export interface CommentNode extends BaseNode { - type: "comment"; + type: "Block"; value: string; startTag?: TagNode; endTag?: TagNode; diff --git a/packages/parser/lib/postprocessor/postprocessor.js b/packages/parser/lib/postprocessor/postprocessor.js index a73ff45d..31f13fed 100644 --- a/packages/parser/lib/postprocessor/postprocessor.js +++ b/packages/parser/lib/postprocessor/postprocessor.js @@ -57,7 +57,7 @@ module.exports = class PostProcessor { ["#comment"](node) { this.skipCommonProcess = true; - node.type = "comment"; + node.type = "Block"; node.startTag = createCommentStartTag(node); node.endTag = createCommentEndTag(node); node.value = node.data;