Fix benchmarks. #6

Merged
merged 3 commits into from Sep 4, 2012

Conversation

Projects
None yet
2 participants
Contributor

lbolla commented Sep 3, 2012

Benchmarks failed to compile with latest Yesod.

Added missing PRAGMAS and updated code to latest Yesod class.

@lbolla lbolla Fix benchmarks.
Added missing PRAGMAS and updated code to latest Yesod class.
9cddaab

@snoyberg snoyberg and 1 other commented on an outdated diff Sep 3, 2012

bigtable/yesod.hs
@@ -18,9 +18,8 @@ mkYesod "Pong"
#endif
/bigtable.html PongR GET
|]
-instance Yesod Pong where
- approot _ = ""
- encryptKey _ = return Nothing
@snoyberg

snoyberg Sep 3, 2012

Owner

Even though the actual code here needs to change, we should still disable sessions, as it has a significant performance impact on microbenchmarks. Nowadays, it would be something like:

makeSessionBackend _ = return Nothing
@lbolla

lbolla Sep 4, 2012

Contributor

Good point! Done.

@snoyberg snoyberg added a commit that referenced this pull request Sep 4, 2012

@snoyberg snoyberg Merge pull request #6 from lbolla/fixes
Fix benchmarks.
234172d

@snoyberg snoyberg merged commit 234172d into yesodweb:master Sep 4, 2012

Owner

snoyberg commented Sep 4, 2012

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment