Experimentation with a better lifting model. #150

Closed
wants to merge 3 commits into
from

Projects

None yet

1 participant

@ghost
ghost commented Sep 3, 2013

--DO NOT MERGE--

The purpose of this is just to let me run automated tests on these modifications to the lifting system, to see whether this preserves the functionality for IDs and embeddings, and in particular passes the tests. I'm unfamiliar, in particular, if introducing Maybes to those areas of code will break things (although the non-Maybe version could be restored easily).

@gregwebs
Member
gregwebs commented Sep 3, 2013

You can run the automated tests locally that are in persistent-test. There are some instructions in the README.

Sean Hunt Fix mistaken lift.
This is a bit of a fragile approach. I guess I see why the previous approach was
used. I can't honestly say which is better.
8ef52f5
@ghost
ghost commented Sep 3, 2013

Oh, ok. Well, hopefully this run will be more enlightening than my stupid screwups :)

@gregwebs
Member
gregwebs commented Sep 5, 2013

The build made it farther, but a similar error occurred.

@ghost
ghost commented Sep 23, 2013

After some experimentation, I'm firmly of the opinion that a) the approach in my previous patch is wrong and b) I don't know how to fix it. I'll upload my progress and someone can try to fix the bugs that come up.

@gregwebs
Member

thanks! The test suite is passing now which is encouraging.

@ghost
ghost commented Sep 24, 2013

Yeah, but parts of yesod break if I try to build with it. Bug in the testsuite, I guess.

@gregwebs
Member

The code in question has changed a lot since this patch was created. I think some of the idea about improving SqlTypeExp was incorporated.

@gregwebs gregwebs closed this May 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment