New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unused extensions. #424

Merged
merged 1 commit into from Jul 22, 2015

Conversation

Projects
None yet
3 participants
@psibi
Member

psibi commented Jul 21, 2015

I don't see why these extensions are required in the module. Tested by building them without the extensions in ghc 7.10.1.

@gregwebs

This comment has been minimized.

Show comment
Hide comment
@gregwebs

gregwebs Jul 21, 2015

Member

yeah, things probably changed during development. good to merge when it passes Travis

Member

gregwebs commented Jul 21, 2015

yeah, things probably changed during development. good to merge when it passes Travis

creichert added a commit that referenced this pull request Jul 22, 2015

Merge pull request #424 from psibi/cleanup
Removing unused extensions.

@creichert creichert merged commit 899958f into yesodweb:master Jul 22, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@creichert

This comment has been minimized.

Show comment
Hide comment
@creichert

creichert Jul 22, 2015

Member

I know this has been discussed at some point but I can't remember the consensus. We can use a more comprehensive set of supported GHC versions with a fairly minimal travis script:

language: haskell
before_install:
env:
 - GHCVER=7.4.2 CABALVER=1.18
 - GHCVER=7.6.3 CABALVER=1.18
 - GHCVER=7.8.4 CABALVER=1.18
 - GHCVER=7.10.1 CABALVER=1.22
 - GHCVER=head  CABALVER=head

matrix:
  allow_failures:
   - env: GHCVER=head  CABALVER=head

before_install:
 - travis_retry sudo add-apt-repository -y ppa:hvr/ghc
 - travis_retry sudo apt-get update
 - travis_retry sudo apt-get install cabal-install-$CABALVER ghc-$GHCVER
 - export PATH=/opt/ghc/$GHCVER/bin:/opt/cabal/$CABALVER/bin:$HOME/.cabal/bin:$PATH
 - cabal --version
 - cabal install happy alex

install:
 - travis_retry cabal update
 - cabal install --only-dependencies --enable-tests

script:
 - cabal configure --enable-tests
#--enable-library-coverage || cabal configure --enable-tests --enable-coverage
 - cabal build
 - cabal test

I'll be happy to make a PR for that if it will help verify more builds. The current travis build is using GHC 7.6

Member

creichert commented Jul 22, 2015

I know this has been discussed at some point but I can't remember the consensus. We can use a more comprehensive set of supported GHC versions with a fairly minimal travis script:

language: haskell
before_install:
env:
 - GHCVER=7.4.2 CABALVER=1.18
 - GHCVER=7.6.3 CABALVER=1.18
 - GHCVER=7.8.4 CABALVER=1.18
 - GHCVER=7.10.1 CABALVER=1.22
 - GHCVER=head  CABALVER=head

matrix:
  allow_failures:
   - env: GHCVER=head  CABALVER=head

before_install:
 - travis_retry sudo add-apt-repository -y ppa:hvr/ghc
 - travis_retry sudo apt-get update
 - travis_retry sudo apt-get install cabal-install-$CABALVER ghc-$GHCVER
 - export PATH=/opt/ghc/$GHCVER/bin:/opt/cabal/$CABALVER/bin:$HOME/.cabal/bin:$PATH
 - cabal --version
 - cabal install happy alex

install:
 - travis_retry cabal update
 - cabal install --only-dependencies --enable-tests

script:
 - cabal configure --enable-tests
#--enable-library-coverage || cabal configure --enable-tests --enable-coverage
 - cabal build
 - cabal test

I'll be happy to make a PR for that if it will help verify more builds. The current travis build is using GHC 7.6

@creichert

This comment has been minimized.

Show comment
Hide comment
@creichert

creichert Jul 22, 2015

Member

Additionally, we only need a few pieces of that script added to what's currently in the .travis.yml

Member

creichert commented Jul 22, 2015

Additionally, we only need a few pieces of that script added to what's currently in the .travis.yml

@gregwebs

This comment has been minimized.

Show comment
Hide comment
@gregwebs

gregwebs Jul 22, 2015

Member

I am all for better travis testing. We don't support 7.4 anymore. adding 7.8 and 7.10 would be great then. Also, we can use stack now if that helps.

The persistent build has some complexity though because the same test suite is re-ran with different flags.

Member

gregwebs commented Jul 22, 2015

I am all for better travis testing. We don't support 7.4 anymore. adding 7.8 and 7.10 would be great then. Also, we can use stack now if that helps.

The persistent build has some complexity though because the same test suite is re-ran with different flags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment