New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to disable http/2? #450

Closed
dylex opened this Issue Oct 14, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@dylex
Contributor

dylex commented Oct 14, 2015

We've been testing every released version of warp and warp-tls and are still getting ERR_SPDY_PROTOCOL_ERROR in recent chrome and network errors in firefox with warp 3.1.6 and warp-tls 3.1.3 and all other packages updated. This causes serious enough problems that we cannot put any of these in production, but keeping warp 3.0.4.2 in production is becoming more difficult because of incompatibilities with other packages. Is there some option just to disable http2 until things work properly?

@dylex

This comment has been minimized.

Show comment
Hide comment
@dylex

dylex Oct 16, 2015

Contributor

For clarity, this is using runTLS. I tried setting onALPNClientSuggest = Nothing but it seems to just ignore this and set it back. The problems primarily happen whenever there is a cookie request header -- otherwise most things work. I'd be happy to try to diagnose, but I'm not sure the best way to get a trace (wireshark can't decrypt with DH and the browsers complain if you disable it; enabling warp-debug doesn't seem to do anything). I'll gladly write a PR to add an HTTP2 option to TLSSettings or Settings if you'll accept it.

Contributor

dylex commented Oct 16, 2015

For clarity, this is using runTLS. I tried setting onALPNClientSuggest = Nothing but it seems to just ignore this and set it back. The problems primarily happen whenever there is a cookie request header -- otherwise most things work. I'd be happy to try to diagnose, but I'm not sure the best way to get a trace (wireshark can't decrypt with DH and the browsers complain if you disable it; enabling warp-debug doesn't seem to do anything). I'll gladly write a PR to add an HTTP2 option to TLSSettings or Settings if you'll accept it.

dylex added a commit to dylex/wai that referenced this issue Oct 18, 2015

Don't override user-specified onALPNClientSuggest
Allows HTTP/2 to be disabled in a round-about way with minimal change.
See #450
@kazu-yamamoto

This comment has been minimized.

Show comment
Hide comment
@kazu-yamamoto

kazu-yamamoto Oct 19, 2015

Contributor

I would like to provide a way to disable HTTP/2.

Contributor

kazu-yamamoto commented Oct 19, 2015

I would like to provide a way to disable HTTP/2.

dylex added a commit to dylex/wai that referenced this issue Oct 19, 2015

dylex added a commit to dylex/wai that referenced this issue Oct 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment