Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow warp-tls to request client certificates. #337

Merged
merged 4 commits into from Feb 22, 2015

Conversation

Projects
None yet
4 participants
@clinty
Copy link

commented Feb 15, 2015

No description provided.

@snoyberg

This comment has been minimized.

Copy link
Member

commented Feb 18, 2015

Looks good to me. One request: could you add a little bit of documentation to these new fields explaining what their values mean? Even just pointing at the relevant TLS fields would be a good addition.

@kazu-yamamoto

This comment has been minimized.

Copy link
Contributor

commented Feb 18, 2015

Looks good to me, too.

@clinty

This comment has been minimized.

Copy link
Author

commented Feb 18, 2015

Sure, how's this?

-- is set to True, you must handle received certificates in a server hook
-- or all connections will fail.
--
-- Default: False

This comment has been minimized.

Copy link
@MaxGabriel

MaxGabriel Feb 18, 2015

Member

Is the tlsWantClientCert documentation supposed to be == to the tlsServerHooks documentation?

edit: oh, tlsServerHooks is maybe duplicated by mistake

Clint Adams
@clinty

This comment has been minimized.

Copy link
Author

commented Feb 18, 2015

@MaxGabriel well, that was embarrassing

@snoyberg snoyberg merged commit 4faabd1 into yesodweb:master Feb 22, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@snoyberg

This comment has been minimized.

Copy link
Member

commented Feb 22, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.