New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warp: add HTTP2 CONNECT support #572

Merged
merged 1 commit into from Jul 26, 2016

Conversation

Projects
None yet
2 participants
@bjin
Contributor

bjin commented Jul 26, 2016

As per section 8.3 of HTTP2 spec, ":scheme" and ":path" should be
omitted and ":authority" is mandatory for HTTP2 CONNECT request.

Treat CONNECT request as a special case for headers check. And also
for CONNECT request, use ":authority" as unparsed path, so that
CONNECT method has consistent behavior compare to HTTP 1.0.

Closes #561

warp: add HTTP2 CONNECT support
As per section 8.3 of HTTP2 spec, ":scheme" and ":path" should be
omitted and ":authority" is mandatory for HTTP2 CONNECT request.

Treat CONNECT request as a special case for headers check. And also
for CONNECT request, use ":authority" as unparsed path, so that
CONNECT method has consistent behavior compare to HTTP 1.0.

Closes #561

@kazu-yamamoto kazu-yamamoto merged commit eca7db1 into yesodweb:master Jul 26, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@kazu-yamamoto

This comment has been minimized.

Contributor

kazu-yamamoto commented Jul 26, 2016

I have merged this pull request. Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment