New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warp: fix HTTP2 requestBodyLength #573

Merged
merged 1 commit into from Aug 3, 2016

Conversation

Projects
None yet
2 participants
@bjin
Contributor

bjin commented Jul 27, 2016

This change actually assumes client provided Content-Length header is accurate. Not sure if it's a good idea or not.

My use case is essentially just regarding the NoBody branch though.

@bjin

This comment has been minimized.

Contributor

bjin commented Jul 29, 2016

@kazu-yamamoto please take a look. Thanks!

@kazu-yamamoto

This comment has been minimized.

Contributor

kazu-yamamoto commented Jul 31, 2016

Surely I will give a look after summer vacation. Please wait for a while.

@kazu-yamamoto

This comment has been minimized.

Contributor

kazu-yamamoto commented Aug 2, 2016

@bjin Is this patch necessary to implement your proxy server?

@bjin

This comment has been minimized.

Contributor

bjin commented Aug 2, 2016

Yes. Without it all GET requests will be chunk encoded (although with
empty body). This will trigger 411 Length required error for some remote
HTTP servers.

@kazu-yamamoto kazu-yamamoto merged commit fc01eef into yesodweb:master Aug 3, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kazu-yamamoto

This comment has been minimized.

Contributor

kazu-yamamoto commented Aug 3, 2016

OK. Merged. Thank you for your contribution.

@kazu-yamamoto

This comment has been minimized.

Contributor

kazu-yamamoto commented Aug 4, 2016

A new version has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment